[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] libs: Fix unstable libs build on FreeBSD, auto-generate version-script
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 15 Feb 2023 15:42:26 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mAVq2WUkPBmRVptWqO60GQ/LiRitT+Evk1FCbEYaE8Y=; b=eygpn8t8CYTi/V1GtkQ2XNTn3qZnm6uExI4AaHmGfZuvkVwo5OO3A6XabbJCwA2y54cBfZQZLlidBpUvJPHzMr6VRO6scbsKbjb1GBhROPzo8r1aPyh3L54/Vf6eXDMXi/7JbH92blS8PjLdKsRdtVzaHTcTNtlXqBIotKtC4tH5CffvZUf6Zie+Rxf5HLjreRfc3sF97iAAcRv2kAQr+L/Qx18A5VvPZhdqlaHq2LN+jinHmHVngTs/qeNcV0nZXxfc4AU16Q7NKu/BV/R8BV0oZ1b4G8OfotjZGhYetd61irWijDpNWxpT1W3IpjNzICtdq4LRhkLu/PrTethXFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EEyjnmRWFsLjZiBZFcI1zKSBz18Y744JZWjsuTJvSH2zuT4r9jOmOccd4KXolVbuVi1HukS8vEXe/EzSsDlTF6PayUrc7DE0X2+qTyZE+qZUjNZ5QJKx+3zhOBoDpLpZQzNxDFndDbDShrbuPH5+eqfBF69GIUS4fQqxrzg1zw6ObCef1JN54ApHz0T4jZ9lUp7bGQ7fM1gloyJATetcEmIMm7+U1UHzRCp07E+UlYa4/E3lWp1xsK3sGrTA5T/dKjw3FjT4/OdZ3U5M6cQKasyQMy+Lsk0ZGjHerP816bnXckoy8tHLl049mLzpHZQmJScyQyCG76L7I5Prz73KBQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 15 Feb 2023 15:42:49 +0000
- Ironport-data: A9a23:XeDjMqp4BtaR6cNedN3ICOSXXqxeBmI4ZBIvgKrLsJaIsI4StFCzt garIBmHOfyCYWSmfdlyb96z8k4AupKBm94wTQM+rC1kHy4bpZuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNVvrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG4IdhnSisaW+bGcEtZUn+cELtDMPrpK7xmMzRmBZRonabbqZvySoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYKIEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqaY10QTDmgT/DjUGaXSQ/ci123X5AeAHc m5I6jgerZALoRnDot7VGkfQTGS/lg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9W9S32H8ayPhSivIiVTJmgHDRLoViMA6tjn5Y020BTGS487FLbv14WoXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94ZRGpFZjFtZ EQ5pvU=
- Ironport-hdrordr: A9a23:yKDIJKnl2l2o5HDoLr9lwcvnHH3pDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/02/2023 3:21 pm, Anthony PERARD wrote:
> Unfortunatly, --default-symver doesn't work on FreeBSD 12, with LLVM's
> LD. Instead, we will generate a temporary version-script.
It was all builds, not just FreeBSD 12, and not really FreeBSD either.
LLD simply doesn't understand the --default-symver.
It's just that the FreeBSD builds are the only ones where we're using
LLD. All the gitlab clang tests are clang+binutils, not clang+llvm. We
ought to change this irrespective.
> diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk
> index 0e4b5e0bd0..cab8e9704a 100644
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -72,6 +77,10 @@ headers.lst: FORCE
> @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp
> @$(call move-if-changed,$@.tmp,$@)
>
> +libxen$(LIBNAME).map.tmp: FORCE
> + echo 'VERS_$(MAJOR).$(MINOR) { global: *; };' >.$@.tmp
> + $(call move-if-changed,.$@.tmp,$@)
It has come up in the past that using literally VERS_ is buggy, because
anyone who copy&pastes too much of the canonical reference will end up
making a compatible binary.
Xen's stable libraries are buggy, and at some point we really do need to
bump them all to 2.0 to fix this.
VERS should be a library reference, so libxen$(LIBNAME) in our case. I
suggest we take this opportunity to fix the unstable libraries.
~Andrew
|
