[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] libelf: relax ELF_PADDR_OFFSET && !VIRT_BASE check for PVH
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Feb 2023 16:08:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jyt9Zb2uyb7Ppza5owbKi9EJTd2x28VYqhSfL00cOqI=; b=NUxtHyuAi12RV/hRAA3vUFqsgjtcK6D0apSkq+eEZ5ptrpmTkbaIB5s63R6H3iJ+pSBU8wRQf3yRoHJa3r5lWLCru22cKONzyMhrIXHdSbQyVZ7COLf8nXaE2aZaD+3wdlb311Zpwp8gvnjtlUX3xDan19pjaI0TvlzaEE9y8UWK3iLaQ38Ir1V3khGcNAZ13PEPj/PmlMPA/xCE6Wp/YrYoUbD8VUwhBXahb8uYVRVFmErKURzfk8qpKchzlOHqSyXq6n8TYyjhLbzdYBt186ggOBEYjGU0uGMdoe7cg0+h0Ybk1QoaHH+TJKzNDmOdwhjlvojkBlGRB/VwBm3n5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DJMEqDCtqsW88J+7nFgVp4KSkaSxp+opvhoOviUvwV1IpHY2uP8gwCOJYb6/ruQgFGhMMmfnRjm1Ha6JfVB8nZ3IxdYrvbPMo0GsiY+Bw4gr/syS5cU3ywr+omuDTZ5YtQ1p+mVHnWaicCQe6u7u7eOH1I4fB4PKf07vKom16pbGaK37boLWqgXk3PVEBTPLoCHxJYDvGvbQ2jC6fP06Hx8N8qqCX1i8SF83ukoClfM70A3bbgjmmGzbGTqfhww9hHsQm+aIrfQHA0xSqfwwlTQDKEDYOgscZP3Oyw73a61i4g0At5CunGRXb4bNow3pC19jAGKsjCh1wLrTS0Ho5g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 15 Feb 2023 15:08:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Both values are unconditionally overridden (to 0) in the "hvm" (i.e.
PVH) case. There's therefore no reason to punish a PVH kernel for
setting the former but not the latter.
Fixes: 632cbaf1243e ("libelf: improve PVH elfnote parsing")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/common/libelf/libelf-dominfo.c
+++ b/xen/common/libelf/libelf-dominfo.c
@@ -419,7 +419,8 @@ static elf_errorstatus elf_xen_addr_calc
uint64_t virt_offset;
if ( (parms->elf_paddr_offset != UNSET_ADDR) &&
- (parms->virt_base == UNSET_ADDR) )
+ (parms->virt_base == UNSET_ADDR) &&
+ !hvm )
{
elf_err(elf, "ERROR: ELF_PADDR_OFFSET set, VIRT_BASE unset\n");
return -1;
|
