[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] automation: Add container and build jobs to run cppcheck analysis
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 14 Feb 2023 17:27:57 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aD4xoZDchmtQQmEqkMkMDcP4VQxFcxj/KCK0hPvM5Vg=; b=DCJUn/St9Dsa+rU5ot2GJh16euCNQGqBfU+gBGgWhv8L4hACXzY6j62OhFyDr62lAcolB4vPnF3Vt99BTZOJ+Ns14dLYN6R8WugQuRq8dUT76UVj4f+YztGFPFdFaXKGZxmJXDst59SCtUAuAQ/UTZrm8b1GVP4gLyXQi5GmJ0XZY1k/+QOL3E1P8m+S0wVveizgQ9JPoledq6P8n2Tozxm9t3gXcyY7Mx3LRx6v3wXOr/B81kNtNPfzpMDXIZxkQ9Vt/GJuLt4Yn+o4rXIMa/CW/6ZeTThqm0wtIstQmxwvkJ8CsIXrp7rDlkXHiPuGiPV69u9Qt7m281jNjl8uGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DGhWJfmPZ/XvffMDnP96YMhyP2R5y0msgsXhXit+B1JEHYmvmVC/d+KfY87QZKX8MNbPXmFgT42AhkB4S/ld8FXNcC9kRko4C6yCh33FSsQSKd1CLf11+xdFc7c+w/oT9gDTtmeh0mzj8cvs1eMzM0S8uh3FZHyNv6DGoSWh4abY+ULAy4jja4on3r4Nyf57RowAKyoGjgZxmlDUh7hpsK7nt3YvCvcxJbf8eZofpekLs4lIGs3npIAWppphDJZQcGS8s7gT4a60EMoiYZKTVAIpahoLbsYE2iHOqqTqpPdPnmVRpjOQDWyzV93Tvqu/Vcmu0XaLJtm8VzdQH/XP3w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 14 Feb 2023 17:28:21 +0000
- Ironport-data: A9a23:4r4xaK4+8J0wIMUkTjkslgxRtPTGchMFZxGqfqrLsTDasY5as4F+v mYbXD+Ba66DNzTzfYh/bIq39EoF78KGmNQySgRsri02Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 KAHCGtVXjW43cW96qK/dfdJ1+UJFZy+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOWF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNNTOfjqa816LGV7kUpDwwRTnTjmNWoqBKhdP9FB Gc3ozV7+MDe82TuFLERRSaQpX+PvhcYHd1KAeA+wAiIxuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8pjqoNS8YBWQLfyMDQE0O5NyLiJookhvFQ9JnEai0pt74Azf9x 3aNtidWulkIpcsC1qH+91aYhTup/8DNVlRsvliRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGS0bYJHd3X5ywmQxg==
- Ironport-hdrordr: A9a23:uboUa63LmkLbfawr9nihzwqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/02/2023 3:39 pm, Michal Orzel wrote:
> diff --git a/automation/build/debian/unstable-cppcheck.dockerfile
> b/automation/build/debian/unstable-cppcheck.dockerfile
> new file mode 100644
> index 000000000000..54b99f87dfec
> --- /dev/null
> +++ b/automation/build/debian/unstable-cppcheck.dockerfile
> @@ -0,0 +1,37 @@
> +FROM arm64v8/debian:unstable
> +LABEL maintainer.name="The Xen Project" \
> + maintainer.email="xen-devel@xxxxxxxxxxxxxxxxxxxx"
> +
> +ENV DEBIAN_FRONTEND=noninteractive
> +ENV CPPCHECK_VERSION=2.7
> +ENV USER root
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +# dependencies for cppcheck and Xen-only build/cross-build
> +RUN apt-get update && \
> + apt-get --quiet --yes install \
> + build-essential \
> + curl \
> + python-is-python3 \
> + libpcre3-dev \
> + flex \
> + bison \
> + gcc-arm-linux-gnueabihf \
> + gcc-x86-64-linux-gnu
> +
> +# cppcheck release build (see cppcheck readme.md)
> +RUN curl -fsSLO
> https://github.com/danmar/cppcheck/archive/"$CPPCHECK_VERSION".tar.gz && \
> + tar xvzf "$CPPCHECK_VERSION".tar.gz && \
> + cd cppcheck-"$CPPCHECK_VERSION" && \
> + make install -j$(nproc) \
> + MATCHCOMPILER=yes \
> + FILESDIR=/usr/share/cppcheck \
> + HAVE_RULES=yes CXXFLAGS="-O2 -DNDEBUG -Wall -Wno-sign-compare
> -Wno-unused-function"
I think you want to be using a mutli-FROM dockerfile here, otherwise
you're including all the intermediate build artefacts in the final image.
See debian/buster-gcc-ibt.dockerfile for an example.
That said, I'm not sure we want to be making custom containers for every
minor tweak we have on a build environment. What's wrong with just
putting CPPCHECK in the normal container?
~Andrew
|
