[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new subdirs
- To: Mihails Strasuns <mstrasun@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Tue, 14 Feb 2023 11:28:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShFv9QsQJY1x51FVPYPXi4rVP16k7PU+/005ZkL4UlE=; b=GvGSDy4L/5KbkOinerZ+1gPI+ZZzUl/n5bnwQqqztLGaDbdoduO09cB1aDwBqoxQ+UzknJ9+gs7b/0hkVde+45njI3aWpaUX/n4Vw4tQnqvz/2Hs8LS5+iqfe3rKeiHVyJC6uGO0H0FQv5LSgJgLWpgp3FEVNSWBbWatXAkz+RbypNuLu/BJUIHWFUm6vH2XtMftPIyVCGD+ilsCpa0WXybUROotmrMbkvHVo284nhvCZd7yThqB1vgbHeNUtY9Nm+FeluMMzYtNM/ntMSZzTXctf/a6Y28G/xWgJ97eQ4iV6pZxtCfAFSvKrNT7AsoW4yvtCMyUbFZ06GI/6Wm1YQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN++LbqUfjTuKXBF1DtTlh0r+vfXnpWFyQhu5F8DKWXPQ1hR317gk9guoCeutsEj+m21nwfystmZuud4ROW5reirQZ+v+xJoxIIiHgLE57+xSElVMIHPKYVBB8tQrUcVPCD8iO7jWEd8758VnhP0wl2bA9WeKEsVEOlQ5Mu/GpYkmgfh3HSvRfGKDvpoyLBPJbtKiOCYS+gQRZyrj/FIu+KfwdbHfyL3RyAY/+CUXY7KN8O1yDamU0OQeqng0PHCyJynsFNCl5xRw5cNuNuq4arPpsKMKp8fu4z7ENWaEe1oaxNF+k56Uv/yBEmJgAQ6UTcD+213+y1GKTVAVboj3A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Raphael Ning <raphning@xxxxxxxxxx>, Bjoern Doebel <doebel@xxxxxxxxx>, Martin Pohlack <mpohlack@xxxxxxxxx>
- Delivery-date: Tue, 14 Feb 2023 11:28:20 +0000
- Ironport-data: A9a23:E0cg56gyEWwyqMgvDgshUdLWX161vREKZh0ujC45NGQN5FlHY01je htvXz2GPv2ONmTyKNwnaom+pkNV7ZWHnNRkGQFlqyhgRSkb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWt0N8klgZmP6sT5gaCzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQWMygTSzvfutj175iDWPc2oZ4/Jo7CadZ3VnFIlVk1DN4AaLWaG+Dgw4Ad2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilMpluG1YbI5efTTLSlRtlyfv XmA+232DwsFPdib4TGE7mitlqnEmiaTtIc6RePjq6Qw3gz7Kmo7Cj5JdQqh4uGFug2CZc9bI BVX5hAwov1nnKCsZpynN/Gim1aBpQIGUsFNFcUz7QifzayS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8hSm7ISgTLGkNTSYBRBkC5Z/op4Rbph7IQ9xuFIa8i9TnHje2z z3ihC0mgLUXhMUI/6y+9ELAhXSgq/D0ohUd4wzWWiev6Fx/bYv8P4iwswGDvLBHMZqTSUSHs D4cgc+C4esSDJaL0iuQXOEKG7Lv7PGAWNHBvWNS81Aa32zF0xaekUp4uVmS+G8B3h44RALU
- Ironport-hdrordr: A9a23:mBfvoKGaoZzozXmKpLqE0seALOsnbusQ8zAXPiFKOH9om6mj/P xG88526faZslkssRIb+exoWpPvfZq0z/cci+Qs1NyZPTUO1lHYS71K3M/PxCDhBj271sM179 YHT0GmMqyUMbGtt7ef3OASKadD/OW6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHZK+7hAAtdeJjC5UKkOXFz/lMuKq7OdpQl
- Thread-topic: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new subdirs
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Mihails
> Strasuns <mstrasun@xxxxxxxxxx>
> Sent: Thursday, January 19, 2023 10:13 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: mstrasun@xxxxxxxxxx <mstrasun@xxxxxxxxxx>; Raphael Ning
> <raphning@xxxxxxxxxx>; Bjoern Doebel <doebel@xxxxxxxxx>; Martin Pohlack
> <mpohlack@xxxxxxxxx>
> Subject: [PATCH v1 2/4] livepatch-build: Allow a patch to introduce new
> subdirs
>
> From: Raphael Ning <raphning@xxxxxxxxxx>
>
> Fix a bug in create_patch() where cp, strip, etc. will fail if the new
> object file introduced by the patch is located in a new subdirectory:
>
> DEBUG: cp: cannot create regular file `output/xen/common/lu/lu.o': No such
> file or directory
> DEBUG: strip: 'output/xen/common/lu/lu.o': No such file
>
> In this example, xen/common/lu/ does not exist in the original
> (unpatched) Xen source tree. It needs to be created in output/ as well.
>
> Signed-off-by: Raphael Ning <raphning@xxxxxxxxxx>
> Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
> Reviewed-by: Martin Pohlack <mpohlack@xxxxxxxxx>
> ---
> livepatch-build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/livepatch-build b/livepatch-build
> index f7d6471..444daa9 100755
> --- a/livepatch-build
> +++ b/livepatch-build
> @@ -232,6 +232,7 @@ function create_patch()
>
> NEW_FILES=$(comm -23 <(cd patched/xen && find . -type f -name '*.o' |
> sort) <(cd original/xen && find . -type f -name '*.o' | sort))
> for i in $NEW_FILES; do
> + mkdir -p "output/$(dirname "$i")"
> cp "patched/$i" "output/$i"
> [[ $STRIP -eq 1 ]] && strip --strip-unneeded "output/$i"
> CHANGED=1
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
|
