[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 03/10] x86/p2m: guard vmx specific ept functions with INTEL_VMX
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Feb 2023 17:55:41 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JqhLLib1GKLw/+3JPpyq4zDc/2kFdwRU9iO3aoWRA6E=; b=O9nKIsiQqfVUJZELSI7qSEXQr+TfVgqymyviUESHyQDDUqN1uHQwc6rjwvNCji47pSVlcdPhaOIW234zWoYhUVFoHENeiOa4bPTN1A6FYdGG5qNibm/uvYZn6iHN0MbDcC9j8v/gWfFjYtG/oqgCNE/KD2kyldPSq5A9mR2kTzaSUwlR/bjIlAOftplWpFTViPbbZDB2YflhIDrZlaivQpWuBnPOGBfr8QLlLUp112db3RTMGzoDvFUOXt305BSsC4XTTI/j8AYmHXoPOKYhIP/frU9L2Krjamkai8SZlyF0IqD58OM9/G0C1HP8kgfUMyYSdKStogxu0RK/bERbxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhJmU64giZB+grtDF7976FgwtAz3wTSji4EJpNGKsQ8F+YldGlqO0EMy3O0HT3LX16D8EOOdR3SHRagOhnrH7ylgUExEbBHX7Tunh6V3A/9pg7Oxwd/5dUUNG/si60mkHsaeyUfA//W621kkFxD3Q0WsecuKE9porWG696nLn8czwID4n7QnSeMFBH5JuNGgFD31lCi+jhzUidMrUC4GFQuFJTLgIXF/labljp4BJETkz44UmtyEgoZ388dR1EVxDeRz2sD6+jAH+XMCLnx5d8U4cxBnbUbL0Nz95D7CUzchZDsls1zYbKz7h3HkrLCQNIaa6d+E0Sng65KCVOOY7A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Feb 2023 16:56:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.02.2023 15:57, Xenia Ragiadakou wrote:
> --- a/xen/arch/x86/mm/p2m.h
> +++ b/xen/arch/x86/mm/p2m.h
> @@ -35,9 +35,25 @@ void p2m_nestedp2m_init(struct p2m_domain *p2m);
> int p2m_init_nestedp2m(struct domain *d);
> void p2m_teardown_nestedp2m(struct domain *d);
>
> +#ifdef CONFIG_INTEL_VMX
> int ept_p2m_init(struct p2m_domain *p2m);
> void ept_p2m_uninit(struct p2m_domain *p2m);
For the calls from p2m_initialise() and p2m_free_one() see my reply
to patch 2. For the calls from altp2m functions, including ...
> void p2m_init_altp2m_ept(struct domain *d, unsigned int i);
... to this one, I think you want to be more rigorous and hide much
(most?) of altp2m altogether when !VMX. (It is perhaps high time
for more of that code to move from p2m.c to altp2m.c, and altp2m.c
then, if it doesn't already, to become dependent on VMX somewhere
in the Makefile in your series.)
Jan
|
