[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 01/10] x86: introduce AMD-V and Intel VT-x Kconfig options
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Feb 2023 16:11:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pI7eCo0GaXU3EHmrxI+t/264N9K810g4h/vYfA5JWo=; b=E8xUqXJOa6v8PrlAxmf8h+EWf7d7S3B5U6n/cUpcEA4br0sEQVK/TWKRYpXxjQckBRgCqFL2MfVemaBbAxQy1dKO9612q4400oYVPymhiXwbKFtzECoDzQT0Y3BWlIPtYoNeJyHZC2BOvsJXV580S78a35E/iCsouuT9L8ly/iGvbn8ePeaFXJEQ9aOoLz0b0VqEKRoFakMGumrwb3XDqDlJ/8u3Dh9O3KBNBQvACSpR/3uPtpz6tSuSu5ZXsYFMq3E5V2VSkJ0eGhBd4nn0JuKmEmL5G59g+HW375PGatUbGKg5D4JmE2jDPHrGq0Lt+YR5uHg/QGRAxncc+5KsBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsPEoj9IVHOqSJq1yZaZ7AmYRs5ncNtipaFzrSJEbv4prcZZyR5PU+/Mj/uWSwqTo9ntJ7s5vsFrmgqlXyN1QPU8MmXQmb0Wt/CWIyvzctHfHvbqqXqHhReVsoyNZMMSA4Puny9/vg3FbHPTxbGZgzZDm3T5wB5rZ78Ugo3k1C0NmHXfCtEXF4DvenjwzGuP1qCxIavKeL/bYQzQSIlxYGA+qi7Oa8ftXUbMSGW+u2QAlc/DYGFv4IG7hVcpuYlnB779umaR9tpv1B0+hdgfXYSjfmy+8RWm2hOVAlC2yraR89ARh88s+kh09SfiEMiq53L4xxmtL1HPhBtU6FjWUw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 13 Feb 2023 15:11:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.02.2023 15:57, Xenia Ragiadakou wrote:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -117,6 +117,12 @@ config HVM
>
> If unsure, say Y.
>
> +config AMD_SVM
> + def_bool y if HVM
> +
> +config INTEL_VMX
> + def_bool y if HVM
I'm not convinced we want vendor names here - I'd prefer to go with
just SVM and VMX.
> --- a/xen/arch/x86/cpu/Makefile
> +++ b/xen/arch/x86/cpu/Makefile
> @@ -10,4 +10,6 @@ obj-y += intel.o
> obj-y += intel_cacheinfo.o
> obj-y += mwait-idle.o
> obj-y += shanghai.o
> -obj-y += vpmu.o vpmu_amd.o vpmu_intel.o
> +obj-y += vpmu.o
> +obj-$(CONFIG_AMD_SVM) += vpmu_amd.o
> +obj-$(CONFIG_INTEL_VMX) += vpmu_intel.o
This code was moved from hvm/ to cpu/ for the specific reason of also
being used by PV guests. (Sadly the comments at the top weren't
corrected at that time.)
> --- a/xen/drivers/passthrough/Kconfig
> +++ b/xen/drivers/passthrough/Kconfig
> @@ -51,7 +51,7 @@ config AMD_IOMMU
>
> config INTEL_IOMMU
> bool "Intel VT-d" if EXPERT
> - depends on X86
> + depends on X86 && INTEL_VMX
> default y
> help
> Enables I/O virtualization on platforms that implement the
This is odd in three ways: For one PV domains (i.e. incl Dom0) also use
the IOMMU. And then earlier on there was a change of yours specifically
relaxing the connection between I/O and CPU virtualization. Plus
finally you make no similar change for AMD.
Jan
|
