[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 13 Feb 2023 11:05:04 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r3/a8WF2x6t8QQ/NlA9CWJmt4lOO0SParreVHDBup30=; b=QeRckJVR/00h1YFyUb5DLRxvcQkDJ6vmIh+/8CTcfje2jJEMw73HpG9l/i/ZjU3WORuoI0aHkJJh3br/uhbvRS+YUttHHN+eSfNTfBBzJJNZzz4/OHIN/6ras3ABf0qraWTIHDFnYKBHdJjWT7pr+QCnKBb2gM9/pTlu5wwsmvA8tXM8WBgbUmVTY4PKyjugIvv1edbnsIIMSm1K2BsQA8siO2mjvnu8Q3LLXTRx0E/19KD43yGc9a2D6rDNZIVlPvZx/cJrO1bPlt9HYiEOzEd0Z9Qs7lsggbDSe/PkhZKlLGp8TIbbV8Chq1YzhGeAFO12vsimLit5nQwmSa6+rg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8NBIJedvppyG3xE0uCNSL0vwmhaUoOD36Y9B/VVEpkIfu4lEao4omwPECT+vUIcuc32321UctRY6addd4VcLs9YnegkiOfwtWgvFLx6yhwOtoPnYfmVt2L9zFpNmbzUnSVYan9VjpG4ur/OBte3pK/CQOQbISokgu4SHvr6fmSVFfDIPwb42inUlS0GUb35crGz3hRhgjhLGj/LoRpdAp3PIKNqhTa0jv9QTKhjflxBlu1ztzb+tjI21gOjsRPhuq3v2rGHBo+P2sLpidrkYz2TeE8B5x3qzeCdVa1XAdmmHvyaMEN8cWuuWEvnfwi14q2R+HaZbYE7Gi5BNxbqYg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 13 Feb 2023 11:05:33 +0000
  • Ironport-data: A9a23:0mgtz62MM6VbslVAifbD5Tpwkn2cJEfYwER7XKvMYLTBsI5bpzcBm 2caUWyCOf3eZzHwLd52b96+/E0Gu8fSn9ZgSwJtpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZnPqgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfCDxp3 sQdazM3Mhmp1tiR/53gcvVgr5F2RCXrFNt3VnBI6xj8VK9jbbWdBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqvC6KklwZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKlB9NNTODpnhJsqFq07G8wGB1VaVC+hMOW1RC8C+hyA VNBr0LCqoB3riRHVOLVVQCisneAuRIbRNN4HOgz6QXLwa3Riy6bDGUZSj9KaPQ9qdQ7Azct0 zehgNfBFTFp9rqPRhq19KqS6zW7OiEXLGoLTS4CUQYBpdLkpekbjR/RT9AlDK+8iPX0Hy39x 3aBqy1Wr6Uei4sH2ru2+XjDgimwvd7ZQwgt/ALVU2m5qARja+aYi5eA7FHa6bNMKdifR1zY5 XwcwZHAvKYJEI2HkzGLTKMVBra16v2ZMTrax1lyA50m8Dfr8HmmFWxN3AxDyI5SGp5sUVfUj IX74Gu9OLc70KOWUJJK
  • Ironport-hdrordr: A9a23:8Vv4/a21vV4K/EBaebqw+gqjBW9xeYIsimQD101hICG9Lfb4qy n+ppomPEHP5wr5AEtQ5exoS5PwPk80lKQFrbX5WI3DYOCIghrREGgP1/qG/9SkIVyCygc/79 YuT0EdMqyKMbESt6+Ti2PUf6dCsbu6GeKT9J3jJh9WPFhXgspbnmBE43OgYzRLrX59dPwE/f Snl656jgvlW046Kuy9G3k+RuDG4/3NiZ78axIeGhg9rCmIgjXA0s+gLzGomjUlf3dmxqoj7m jfjxa8xqKttZiAu0Ph/l6Wza573PPn19tdBNeRkIw0LSjhkQylfZlmQPmjuz8yydvftWoCoZ 3vmTtlF9lv43nRem2zvDTs3hTtyzYo5TvDzkKVmnHuuNH+X3YbDMVG7LgpKCfx2g4Dhv056q 5RwG6Dl51ZC3r77XzAzumNcysvulu/oHIkn+JWpWdYS5EiZLhYqpFa1F9JEb8bdRiKprwPIa 1LNoXx9fxWeVSVYzTypW902uGhWXw1A1OvXlUCgMqIyDJb9UoJjnfwhfZv3kvoxqhNCaWs1N 60d5iAU4s+CvP+WJgNR9vph/HHTVAlDyi8dl56am6Xap3vc0i92qIfqY9Fl91DdPEzvesPsY WEX1VCuWEofUXyTcWIwZ1Q6xjIBH6wRDL316hlltNEU5DHNfPW2Be4ORgTutrlp+9aDtzQWv 61Np4TC/j/LXH2EYIM2wHlQZFdJXQXTcVQ478AKh+zi9OOLpevuv3Qcf7VKraoGTE4WnnnCn 9GWDToPs1P4k2iR3e9ihnMXHHmfFD54PtLYeLn1vlWzJJIOpxHswATh1j87saXKSdauqhzZ0 d6KKOPqNLMmYB3xxe+04xEAGsoMq8O2sSTb5pjn35+D3/J
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13/02/2023 10:54 am, Xenia Ragiadakou wrote:
>
> On 2/13/23 12:09, Jan Beulich wrote:
>> I keep forgetting why putting it on just the declaration isn't
>> sufficient; I
>> guess a short comment to that effect next to cf_check's definition in
>> compiler.h would help).
>
> Yes, that would help. I don't know why it is not sufficient placing it
> just in the declaration.

Because it's part of the function's type.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.