[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping²: [PATCH v2] xen: credit2: respect credit2_runqueue=all when arranging runqueues
- To: Dario Faggioli <dfaggioli@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 13 Feb 2023 11:41:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rpJK4eE/EBvGTE5bNTsY4VYJC3L1bXoChiUA8fT0EGA=; b=MVwclZYXOtG53jVZWTkOolJLTUmcZFBxzB+jD7vO4gmpcsHTBQwQ34IzejunKwzuvOS+4uKtDiKIu1SKykWH/0qQk0i2nKcguPyEZlxYBtffrwpBnXRoAT4cckXM+CVff8/DXNM2lACAxQ2Iy+Oqz4tJ2qRKbvm3y/yyYTM3Eoj4CzQ+kdwwImuM+oe1R9A/AOKydfZHuzmL8G+SNe1x37HT1uROoekA9O1PFXzvqtlq+N0kIRsxKEXv2ocHcdHdxPZGnXPvf14z7nzt+PS6YBYKKFxmYUlMeu0CGFxq5nc7OaVYxFbbFaFavpQddjGIGCgyn41Q4W3WpN7tdxJWaw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVnMwudzifh3qrS8PT+nZ6ldhHBCd77ruMZercGpkupxX8peduDyA86gGSbG1ZZca/TPJm+rxbM4rqKXA2yB3JiDQZnlTTz3NcdaVq6b35DusgoWenSHnADXP7xGwD4blePN0RvbD500VfarA1NsKz+0vOjYIdEAy+jRWFSnpe20ktoUG+Fe78F/VeP0IyVoDy2bvznZBDlG8rlgAnwQwZmTEM9uGO7GLzdWMdQPLQmC5EFmPR07FyaCW4KUsFaxGwfqKXVh0Q943z6hquzrk4QqBX6yyEWWxKq2IIMX7OFufErsZ0VrkYRB40kv9jO/Rp8o/obREK6/kKBqAnsjoQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 13 Feb 2023 10:41:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.12.2022 12:41, Jan Beulich wrote:
> On 03.10.2022 18:21, Marek Marczykowski-Górecki wrote:
>> Documentation for credit2_runqueue=all says it should create one queue
>> for all pCPUs on the host. But since introduction
>> sched_credit2_max_cpus_runqueue, it actually created separate runqueue
>> per socket, even if the CPUs count is below
>> sched_credit2_max_cpus_runqueue.
>>
>> Adjust the condition to skip syblink check in case of
>> credit2_runqueue=all.
>>
>> Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a
>> runqueue")
>> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>> Changes in v2:
>> - fix indentation
>> - adjust doc
>>
>> The whole thing is under cpu_runqueue_match() already, so maybe
>> cpu_runqueue_siblings_match() isn't needed at all?
>> ---
>> docs/misc/xen-command-line.pandoc | 5 +++++
>> xen/common/sched/credit2.c | 9 +++++++--
>> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> George, Dario - any chance of an ack (or reasons not to)?
Another two months later I'm inclined to commit this with just Jürgen's R-b
(assuming it still applies cleanly). I'll give it a day or two more ...
Jan
|
