Re: [PATCH 3/6] xen/x86: Replace GPL v2.0 copyright with an SPDX tag in *.h

[Julien Grall <julien@xxxxxxx>]

Hi,

On 09/02/2023 23:00, Julien Grall wrote:
> diff --git a/xen/arch/x86/include/asm/hvm/vpt.h 
> b/xen/arch/x86/include/asm/hvm/vpt.h
> index 74c0cedd11cc..c0e1380076a7 100644
> --- a/xen/arch/x86/include/asm/hvm/vpt.h
> +++ b/xen/arch/x86/include/asm/hvm/vpt.h
> @@ -1,19 +1,8 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>   /*
>    * vpt.h: Virtual Platform Timer definitions
>    *
>    * Copyright (c) 2004, Intel Corporation.
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms and conditions of the GNU General Public License,
> - * version 2, as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> - * more details.
> - *
> - * You should have received a copy of the GNU General Public License along with
> - * this program; If not, see <http://www.gnu.org/licenses/>.
>    */
>   
>   #ifndef __ASM_X86_HVM_VPT_H__
> diff --git a/xen/arch/x86/include/asm/iommu.h b/xen/arch/x86/include/asm/iommu.h
> index fc0afe35bf6b..8e1e0ad9ee18 100644
> --- a/xen/arch/x86/include/asm/iommu.h
> +++ b/xen/arch/x86/include/asm/iommu.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
Hmmm... I didn't notice that the licence text wasn't removed in iommu.h. 
It looks like this is...

>   /*
>    * This program is free software; you can redistribute it and/or modify it
>    * under the terms and conditions of the GNU General Public License,
... because '*/' is the indented the usual way. I will add the pattern 
in the python script and also harden it to throw an error if it can't 
replace the licence text.
Cheers,

--
Julien Grall