Re: [PATCH] tools/ocaml: Drop libxl bindings

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 9 Feb 2023, at 15:43, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> 
> There are significant issues with these bindings, and their companion half in
> Xapi was deleted in 2018
> 
>  
> https://github.com/xapi-project/xen-api/commit/203292ebe0c487d7ae4adb961a6d080f4fbe933d
> 
> owing to there having been no development of these bindings since 2014.
> 
> In the unlikely event that we'd want to reinstate them, they'd need reworking
> basically from scratch anyway.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
> CC: David Scott <dave@xxxxxxxxxx>
> CC: Edwin Török <edwin.torok@xxxxxxxxx>
> CC: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
> 
> I'm unsure whether to drop xentoollog.  They're technically orphaned by this
> change, but could be used in principle by the other bindings.
> ---
> tools/ocaml/Makefile                 |    4 -
> tools/ocaml/libs/Makefile            |    2 +-
> tools/ocaml/libs/xl/META.in          |    5 -
> tools/ocaml/libs/xl/Makefile         |   71 --
> tools/ocaml/libs/xl/genwrap.py       |  582 ------------
> tools/ocaml/libs/xl/xenlight.ml.in   |   94 --
> tools/ocaml/libs/xl/xenlight.mli.in  |   93 --
> tools/ocaml/libs/xl/xenlight_stubs.c | 1663 ----------------------------------
> tools/ocaml/test/Makefile            |   55 --
> tools/ocaml/test/dmesg.ml            |   17 -
> tools/ocaml/test/list_domains.ml     |   26 -
> tools/ocaml/test/raise_exception.ml  |    9 -
> tools/ocaml/test/send_debug_keys.ml  |   13 -
> tools/ocaml/test/xtl.ml              |   39 -
> 14 files changed, 1 insertion(+), 2672 deletions(-)
> delete mode 100644 tools/ocaml/libs/xl/META.in
> delete mode 100644 tools/ocaml/libs/xl/Makefile
> delete mode 100644 tools/ocaml/libs/xl/genwrap.py
> delete mode 100644 tools/ocaml/libs/xl/xenlight.ml.in
> delete mode 100644 tools/ocaml/libs/xl/xenlight.mli.in
> delete mode 100644 tools/ocaml/libs/xl/xenlight_stubs.c
> delete mode 100644 tools/ocaml/test/Makefile
> delete mode 100644 tools/ocaml/test/dmesg.ml
> delete mode 100644 tools/ocaml/test/list_domains.ml
> delete mode 100644 tools/ocaml/test/raise_exception.ml
> delete mode 100644 tools/ocaml/test/send_debug_keys.ml
> delete mode 100644 tools/ocaml/test/xtl.ml
> 

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>