[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: Make FILE symbol paths consistent
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 9 Feb 2023 14:47:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ahjvpTi7fKt9B0aA/ag7jEDPCf+7ZgQC4lifzUe4apQ=; b=m3P4zA7FFqXXnanq/sPYz/jgZJioblXBasOjFTK+MGuDPx6paY8nBk0ALCNziC+HD+rqeoOdIMrG8nHZR8b67atjW49DdGYyg6yyH8OzpRbIQ5+rwmqwF63Di1qCN28uo/d4bfvJxWSDc1Y7wCxfvKO0+0jOjAstPVEvfnb6mTHpCmk7sTyRo8I2zlnzV56gIHVqONmavmlE1SAi+VvP0H7NJH4S7m98TtssSx9cGDpDDe/wVlG8MuTwWR1ETLBOsDGRMrRyqJ+GcUzS/okPk65I0skyLOUrbyHKTkLpYyb+9+0oRzT/dPu68P//aibTDunikUwbO6zQTpSS2iGQ3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hRHXfMZuK4cHoXID0uSOOd5L/P/GOS0Jbk1n7pdPDZihB9d2LMMyzJfqmjvjgO/eheexmZ6F47KNq+mVOCk4zdFW/YeDJGXyTajqc3Kc1hOAaZv6g1oSxXF6wDmKnv9Q4PHa8CDUXbkrGi835MEcDr2+Gzyy5KLHJuJD7vTQEXgqEKjjm8MxlA4ir284Qcxst5MuhtzycmMNLbivg+zwsWCpyym1QD0DrfnZytY0RgDDFltY5GyvWFKksrakEFPwWSGwyAb8vnMmluO8K35A2s0NfZ/C5v5QyJkqt9ODJ/yZOiYChmHqT++hn2oBpOF0BeFzDkv8+SpQkn4qNeuqIQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 09 Feb 2023 13:48:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.02.2023 12:40, Ross Lagerwall wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Thursday, February 9, 2023 8:44 AM
>>
>> On 08.02.2023 18:24, Ross Lagerwall wrote:
>>> + rel_path = $(patsubst $(abs_srctree)/%,%,$(call realpath,$(1)))
>>
>> Personally I'm against use of underscores when dashes would do, and using
>> a dash here would also be consistent with e.g. ...
>>
>>> cmd_objcopy_fix_sym = \
>>> - $(OBJCOPY) --redefine-sym $(<F)=$< $(dot-target).tmp $@ && rm -f
>>> $(dot-target).tmp
>>> + $(OBJCOPY) --redefine-sym $(<F)=$(call rel_path,$<)
>>> $(dot-target).tmp $@ && rm -f $(dot-target).tmp
>>> else
>>> cmd_objcopy_fix_sym = mv -f $(dot-target).tmp $@
>>> endif
>>
>> ... the several visible uses of $(dot-target) here.
>
> I'm not sure if there is much consistency since other variables like
> abs_srctree and abs_objtree also use underscores but I can change it
> if you prefer.
These two variables had their names kept from their Linux origin, iirc,
so they aren't an overly good target for comparison. Nor are, for the
same reason, the various cmd_*. Linux, sadly, isn't consistent in that
regard ...
Jan
|
