[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH for-4.17 v6 5/5] tools: Rework $(xenlibs-ldlibs, ) to provide library flags only.
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 8 Feb 2023 15:10:18 +0000
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 08 Feb 2023 15:11:05 +0000
- Ironport-data: A9a23:h+jw7q4Dhfwp4Kqn5yx9xwxRtBXHchMFZxGqfqrLsTDasY5as4F+v mcYXTrXaK2LYGKje4hxPIy+o0lUsMfXnIVlSwporS8yHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoT7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5my dI8cDkIKSy4uM2J7q7hSdlQrO0fM5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9zxvG/ j6ZpTuR7hcyOMSH9TCvqyOQvtDJwTP2UogyEIHn36s/6LGU7jNKU0BHPbehmtGmjmauVtQZL FYbkgIntaUo/VanZsX8VRa/5nWDu3Y0WdVKFPYhwBqQ0aeS6AGcbkAUQzgEZNE4ucseQT0xy kTPj97vHSZosrCeVTSa7Lj8kN+pEXFLdylYP3ZCFFZbpYC5++nfky4jUP5fPorth9iyJQrP7 A+ksHI9t4k5pPIUgvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlznTlfQkbIF2+Cx9p2hX4iEUnIZQu/i/FF5WLLdEJu2EWyKuE3685ld7Vj K3741s5CHx7ZiHCgUpLj2WZVawXIVDIT4iNaxwtRoMmjmJNXAGG5jpyQkWbwnrglkMh+YlmZ 8jGLpfwUyhHU/s5pNZTewv7+eVzrszZ7TqMLa0XMjz9iebODJJrYedt3KSyghARs/rf/VS9H yd3PMqW0RRPONASkQGOmbP/2WsidCBhbbiv8pw/SwJ2ClY+cI3XI6OLkOxJlk0Mt/g9q9okC VnkCxQGlAKg2y2vxMfjQikLVY4DlK1X9RoTVRHA937zs5T/Se5DNJsiSqY=
- Ironport-hdrordr: A9a23:sxcuL6ovZLagQtWXGptiuWIaV5rdeYIsimQD101hICG9Evb0qy lhppQmPH7P+VAssRQb8+xoV5PufZqxz/BICMwqTNWftWrdyQyVxeNZnOjfKlTbckWTygce79 YET0EXMrbN5DNB/KLHCWeDcurJwLO8gd+VbeW19QYScem9AZsQnjuQCWygYz1LrBEtP+tBKH IFjPA32gZJfx4sH7yGL0hAZcfvjfvRmqnrZBYXbiRXlDVn3VuTmcXH+wHz5GZlbw9y
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 08, 2023 at 08:48:33AM +0100, Juergen Gross wrote:
> On 20.01.23 20:44, Anthony PERARD wrote:
> > LDLIBS is usually only the library flags (that is the `-l` flags), as
> > proposed in GNU make manual, while LDFLAGS would be extra flags such
> > as `-L`.
> >
> > Rework the make macro $(xenlibs-ldlibs, ) to only provide the library
> > flags. $(xenlibs-ldflags, ) already only provide the extra flags like
> > the -rpath-link flags.
> >
> > Also fix "test_%" recipe in libs/light as "libxenlight.so" in
> > $(LDLIBS_libxenlight) is been replaced by "-lxenlight". Instead of
> > just changing the filter, we will start using the $(xenlibs-*,) macro.
> > For LDFLAGS, we only needs the one for libxenlight, as the one for
>
> nit: s/needs/need/
>
> > toolcore and toollog are already in $(LDFLAGS), they are dependencies
> > to build libxenlight.so.
>
> I don't like this very much. toolcore and toollog are used directly by
> the test_% programs, so I don't think we should rely on libxenlight
> depending on them.
Ok, I can add them back, it isn't much of an issue to have duplicated
flags on the command line.
Cheers,
--
Anthony PERARD
|
