Re: [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Tue, 2023-01-31 at 14:37 +0200, Oleksii wrote:
> Hi Julien,
> 
> On Tue, 2023-01-31 at 11:42 +0000, Julien Grall wrote:
> > Hi Oleksii,
> > 
> > On 31/01/2023 11:17, Oleksii Kurochko wrote:
> > > Because printk() relies on a serial driver (like the ns16550
> > > driver)
> > > and drivers require working virtual memory (ioremap()) there is
> > > not
> > > print functionality early in Xen boot.
> > > 
> > > The patch introduces the basic stuff of early_printk
> > > functionality
> > > which will be enough to print 'hello from C environment".
> > > 
> > > Originally early_printk.{c,h} was introduced by Bobby Eshleman
> > > (
> > > https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d
> > > 1aab71384)
> > > but some functionality was changed:
> > > early_printk() function was changed in comparison with the
> > > original
> > > as
> > > common isn't being built now so there is no vscnprintf.
> > > 
> > > This commit adds early printk implementation built on the putc
> > > SBI
> > > call.
> > > 
> > > As sbi_console_putchar() is already being planned for deprecation
> > > it is used temporarily now and will be removed or reworked after
> > > real uart will be ready.
> > > 
> > > Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
> > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > > Reviewed-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
> > > ---
> > > Changes in V8:
> > >      - Nothing was changed
> > > ---
> > > Changes in V7:
> > >      - Nothing was changed
> > > ---
> > > Changes in V6:
> > >      - Remove __riscv_cmodel_medany check from early_printk.c
> > 
> > This discussion is still not resolved. I will echo Jan's point [1]
> > and 
> > expand it. There is limited point to keep sending a new version for
> > small changes if there main open points are not addressed.
> > 
> > Can you please look at settling done on the issues first and then
> > send a 
> > new version?
> Sure, I won't provide new patch series until the issue will be
> resolved.
> 
Since Alistair and Bobby agreed that the check is needed I'll send a
new version of the patch series.

> This patch series has been sent to resolve an issue with CI&CD which
> I
> missed after the renaming of task for RISC-V in build.yaml.
> 
> ~ Oleksii
> > 
> > Cheers,
> > 
> > [1] 1d63dd9a-77df-4fca-e35b-886ba19fb35d@xxxxxxxx
> > 
> 
~ Oleksii