[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 6 Feb 2023 14:55:47 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bkCoKdqI9O51GEANP5YqtjyZlKvcMxG7gGMEGuJdtak=; b=WzyAVN68liEeUvG6eRNIR5Ev5gu0whNINCCds0GZkQFkdp7OcPsdEFpJpKjEIdjDFxKq1SZxzsB4Harm6IJNfTm52RZlcOFLlhtC5exnxUHtikKisAIEUw0cH2qVeDYmgIzXSC6TdsWIdwk2GjwpyOTE54M28d+3ZT4uGuVJiP9o5cC5MPyTpEEcld+zhvYjySKRlk1lS7z1Co0ZaqQWnRarSAqauQoBtlGXHnTYlNSRsbwRngeKXs2iBnS982z0FtGtJOdWzwrKi+f7utdWjfmaBabUZhaIzCKJ4mfGKYDgtkvmD3blAKwhPIgiBgqf/sWbWfVyDDs1rk0goY209g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVCTsS0YP6IAu1j/8gJFiMabtdFrJ59ETJ2ecCoWrcTTex93z/KiCsJIf/Ls6BuBUkgsfeDqYMFb/Sc1Y3BANc/IsuqCOFCtcZN9q3wOzPAqCOaYTfZD8pjsmKBqyDDbpCAtHvTzXnDHM0GqS2V14FA5KVWjVpb3Q+I1jduX7PN3T0Cig/+Ahb+MF4nahj8sAKzUH0QvQ2UTfT3GSJGVlZc+U/IfOXdiRf5wldRyr6OEbjgjtfgnV9EGJXP0lJRYlXSdVJJXpcky3jKdW9YPqwVdJCo+TC2WGwXRelP2YUbVXy6SLCAXunmWASmS2FcZAgEaqyoboEouIjrkV6P2Eg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Mon, 06 Feb 2023 14:56:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZOAMXy1ML+LQFIECFNoctrCf/pa7CAoAAgAACbgCAAAEwgA==
- Thread-topic: [PATCH v3 2/2] xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros
> On 6 Feb 2023, at 14:51, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
>
> Hi Luca
>
> On 2/6/23 16:42, Luca Fancellu wrote:
>>> On 3 Feb 2023, at 19:09, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
>>>
>>> Macro dt_irq() is broken because the macro parameter has the same name with
>>> the struct dt_irq member "irq".
>> I’m not sure about the wording “broken”, it should work anyway or am I wrong?
>
> No, it won't work because the structure member will be substituted as well by
> the macro argument (for instance dt_irq(blah) will be replaced by
> (blah)->blah).
Yes you are right, I was reading it in the wrong way!
>
>>> Macro dt_irq_flags() is broken as well because struct dt_irq has no member
>>> named "flags".
>> Yes this depends if the macro was meant to access the structure dt_irq, I’ve
>> had a look
>> on the commit introducing it but I could not figure out the usage.
>
> Given the macro name, I assumed that it was meant to be used for accessing a
> dt_irq field.
Yes I would come to the same conclusion
|
