[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 6 Feb 2023 14:26:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=53/wvQ0s8QaVe90HQ1X8qbCO97kGb2IAOzWaQMThuW8=; b=esXnx3NjCKgUOe3KY+PrGU9E7h9gxQYTn0i0v7hi2SUnMShgfYMIoW21cGI5DjDDL7TBceD1VnzNQAPynyOYS6OBkqEFONGKnVvZjUmJSFyNooSx56EJikkeEutsUL8Zko0yk9kGhni1Boo33gBZlcsydqdpoWbbVDhwXnF2HvJJR3Txo/rqgenkWEgQ0WK26Gz2VN0Y4TZtXFNCc2BlBsHOKngyTVRNhL1ojQL3Bhj/vJBl+hIT1EBOFANAb9TvBI5A1RC6mB3AHgBOHagACTU2grZCuGS00XhCrfmGG8r3G41SF5YpsbG47wN5Fd3oKO2HCEjfqCV3Uf1MhB4H9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dIo3Uf6ZmgFtmSQSMrORWouiQqD6KMHWPYPfL+VsxArC6sVkM8c0BGtqjKFEcmYUOeFp3IE/MTkifIBYiyHm8cLC9qAdfcchNEQQDgEQnVFA+R1JS/cNCwOcHbo73vWTQv8ULl9MsVLwrqG/dNiE+v1UhtTZ7vMUngQjJkSHSw0myPiiLRFul5NM6SJhYzBr+quWpTJr6bph33yKTSeQxK+MF3BBl57d8ONJl7O363P/vmJuHQyu7uV1s72Rwak+MZnJZh2Z8K4Cyz10LJ3helJjt2Iqy4MmoWk5MVbjk2S79oQ3V+vCmgP+zgJVRAjMi3F/cngdOsrrRrauW3JzFw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 06 Feb 2023 14:26:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZOivabZ9Ut2J3Nka3T18Z2Kyz4q7B+X8A
- Thread-topic: [PATCH] xen/arm: Print return code from domain_create and construct_dom{0,U} on panic
> On 6 Feb 2023, at 13:05, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> This might be helpful in providing additional debugging information (in
> most cases, at least to distinguish -EINVAL from -ENOMEM), so modify the
> code to include printing return code in panic message. In create_dom0,
> move the call to alloc_dom0_vcpu0() to a separate condition and call a
> meaningful panic message.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Hi Michal,
The code looks good to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
