[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86: do not include asm/hvm/support.h when not used


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 6 Feb 2023 14:01:48 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RUYBT5u2O+lSXz0eh+VZUuWrUKtpKdr8gNbF+5CKt6k=; b=Tk+453IokEbiDeMO1qZ8UQG/WMFTy8yloCMgMhHgDLRdWRJYSGPmz2C1b1ef/fdH8yMIKT0QlfCPXeVn97nCZ+WqUrfN8czXZU3tzeB0eVcJRlRXb4E/lq76OVN1Use7EOdEBjR7o//y7aEUWUl7Z4FphaxImGaOuwTE7z6LyGCWDug+sQ3Jx4Gz8+V0XYxbZta41yE//uJzSqinPJTWMHgEzQNOwfJPpUHb/dJE1AOaab3QRvYQ4+oKZNaRTUstIC24YaKXsI2J9RpLDKI3F1+BWOPJXR98k9Mw4kHJFPGZvnIZqW6FzAa2c8UarkGGAV2nlyKLnJzG7lHeJFy3+Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2UFhnChCzkM7VNIYHqL1YvmxQYTnGvC8ii4SHQ2+91DLwoBNt69nB6QhXWuwM/FHzRDhMSKt369zFbB046b4nVG6u7l65pOBOCvDDSQEp66Tg3rpORVvJAy/T5DUPPVl0M0xc9ZDD/o0KQbb/V0z1/nxXn/zcIeNkdXPzGuJgp3yYo2PEqXwjqFwE3TIKAI9cq/NVarx4RN8b8WId6VxQyKgytURVrdyJEWexHjjgIxnnQrBRuhacvQmPzv05x7Wggg/S38n6/2aMU4RTX8XSXJCySUj60sP8T0yIjkao73ASQtNpUsKmNwkNRUOJLeXzdTb5EBu8iUCVNy3Pb5hw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 06 Feb 2023 13:02:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.02.2023 13:42, Xenia Ragiadakou wrote:
> --- a/xen/arch/x86/emul-i8254.c
> +++ b/xen/arch/x86/emul-i8254.c
> @@ -34,7 +34,7 @@
>  #include <asm/time.h>
>  #include <asm/hvm/hvm.h>
>  #include <asm/hvm/io.h>
> -#include <asm/hvm/support.h>
> +#include <asm/hvm/save.h>
>  #include <asm/hvm/vpt.h>
>  #include <asm/current.h>

To be honest I'd prefer if only the HVM-specific part of this file had
this new #include (and ideally the other hvm/ ones would move there as
well, but I can see this being beyond the scope of what you're wanting
to do).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.