[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/11] xen/arm: add cache coloring initialization
- To: Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 24 Jan 2023 17:20:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dDsn2I1YqpMu1j10i9ClhnhS1OWA7edRBW7WPl8YX0g=; b=kmXBCq6g5zOX9p444QB0V/Vhy0Q4seZQ7MOIIrZipSBMzsM1sBsVEVavu1gYcEQzwa1bprvysDg9KtmsHbz/TIzAkPhsk+ZGrEpjEzVYziVabdQW9F/22x638DVdprf2VAxlc9e6f80ZqSuZPM3ADrXA5cXw1W3M+Zl+B3TWt+Wp/H0M9wRR93M1HPxvv940XEjWmT1mcTz1MNP3oEWS8Hzc9BpF+rowd0jiOPVYP77g/v0EZvtVoG+fXd+t5IspeAr4BAwKSdod3r+dBIp4/0ZD8iaWq2o3bxLu6Xwnnk4dbAb2LhtZ1bQTeBNk4OYlX1jUiYLYDEmCApYsGODphw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkFp+3iyWi8jmYyqAr1Cue+7KTxoPL6/DRRrK8vB1x/zbUb1Dwiars0PelzKHiInzszuQ8i23zjyJfDlxJCSujetz2BNmxxILRSm/+LPZiuKt9yJQhLZmvIlUOoeQFUYKxrJTuwkeLOeD5MSWKYaLauy5loiH9zaKaQVbm8ddHPzkAkDsLhKL8iopx7p36yxb9JKPVih2L7H8Zl+mKiDYhtdhPsbFZyKaiuuj83cv/uMRUr1wMroojXygXMotH8lHCxDgyAIUe8bAgyK6CB5crV+06KWEtw2BmXI7Wk5AcvjoRU2UZHAVoJduKg/3JoRwCmUpr/1bDVAmz+0lJt/dg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Jan 2023 16:22:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.01.2023 16:47, Carlo Nonato wrote:
> +static unsigned int *alloc_colors(unsigned int num_colors)
> +{
> + unsigned int *colors = xmalloc_array(unsigned int, num_colors);
> +
> + if ( !colors )
> + panic("Unable to allocate LLC colors\n");
Already for Dom0 creation I view this as an unacceptable form of error
"handling". Later you even hook this up to a domctl for DomU creation,
at which point panic()ing is entirely unacceptable.
Jan
|
