Re: [PATCH v3 04/17] tools/xenstore: introduce dummy nodes for special watch paths

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 17/01/2023 09:11, Juergen Gross wrote:
> +static void fire_special_watches(const char *name)
> +{
> +       void *ctx = talloc_new(NULL);
> +       struct node *node;
> +
> +       if (!ctx)
> +               return;
> +
> +       node = read_node(NULL, ctx, name);
> +
> +       if (node)
> +               fire_watches(NULL, ctx, name, node, true, NULL);
> +       else
> +               syslog(LOG_ERR, "special node %s not found\n", name);
NIT: How about using log() so it is also printed in the trace log? This 
would be handy to avoid having to check multiple log files.
With or without:

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall