[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 11 Jan 2023 23:56:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wJnjP+gFDwTbENByDjE9DAEGhVAVwRyGY6u9OSpZ5g=; b=nCDVBh7j/hSdw0qXjE0if9FxhUOYgPYKX+JoZ0eJ71bUZpv0dhpLesG4Crj9rQ7mT1FVGcUNAQxH2rCsb2epZQc0/5onHoLyfFxKDdX7nGofzuEP2GbG+4Xn3yBcC4FIgQyrYEOXLEj97NhXf3w9ytGHHc9dleWEJ+1XP8fvPPQYAquGrK+ITuibmcLSgd/gung6c/QfBiSySSVknplVdd4WTRnqxgRbJoFGTe9QfwRQ9nJa5vyt+Tqf6BPIZD0TCqHUtC5zlk4gkr08lvmSck0iPvhnY07xSB7smFlfXWSfHpMx0t3+CizoGgdUdjNbTNYMnimDz6d27nfkel3aNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgP+NOhqtpBrg6HrrVxrdpTCBZRm6cLfGbDKnv84X+QZh8t74ztiC3nghUQDT3CymIg9HuP2x6ufEhw0R4KT5tT3PpZro2VgQkSHVGf8CoKyIRfj2dsPOjJNQiURk03Z2Z33yJAk1mxukjK0fu2icF1poD8PxkGc5X5o5c6MHKAbI/8IHJ+b3Ug/1jXPh6cTI7OC2pTEYE1w7L4qrrRbXnH5NCIt0dRGzH8+tjOSayBiqHgqwsiFXCD97zRVEjJWiU6mAiTrdFQK5ZMKSR+bhvGxIws1DCc2XvxIsCnAfsog81CQ1Nw03YCC7WZFYYFqAbqs4Vt9Wt4VpKEl4AK+qQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Wed, 11 Jan 2023 23:56:49 +0000
- Ironport-data: A9a23:JtIO1KO0ShuUm83vrR2UlsFynXyQoLVcMsEvi/4bfWQNrUp21D1Vn GBLCDyBaareZGvzeop0boq19kMB6p/QnYAyHQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo42tB5wVmPpingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vdqCEN83 +ZAE25TVT7YvLuR64Khc9A506zPLOGzVG8ekldJ6GiBSNwAHtXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+vJxujCMpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexH2rBtpORdVU8NZLvkyQ7EtKKSEHRGSbsfOdjGmuC/h2f hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaETQUKEcSaClCShEKi+QPu6k2hxPLC9xlT6i8i4StHSmqm mjV6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHY1 JTYs6ByNNwzMKw=
- Ironport-hdrordr: A9a23:2BHan6yAukz+po36jnSbKrPxaeskLtp133Aq2lEZdPU1SL3sqy nKpp906faaslYssQ4b6Ky90cW7IE80lqQFkrX5Q43SPjUO0VHAROtfBODZsl7d8kPFh4tgPa wJSdkANDWZZ2IXsS6QijPWLz7uquPrzImYwd77i1NRZUVSbadkhj0JeDpy0CdNNXd77V5SLu vt2iKDzQDQCEj/Ff7LYkUtbqz4vtjWk5CjSQcebiRXkTWmvHeT8bvnFBrd9QsfVj4n+8ZezU H11zbh47mlsbWdwhvRvlWjiKh+qZ/a095eA87JrNYTJi6EsHfPWK1RH4eauSwzoqWUyHtCqq i1nz4Qe/5r7m/XfCWOrQDz1xLG2DIjgkWSsmOwsD/YuMnkQzB/NMZbn4JedXLimjAdgO0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZJcSfDC5mFmcp2UCTS4rgBv7O2q6Z5R0A
- Thread-topic: [PATCH v2 8/9] x86/shadow: call sh_detach_old_tables() directly
On 11/01/2023 1:57 pm, Jan Beulich wrote:
> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -2264,6 +2264,29 @@ void shadow_prepare_page_type_change(str
> shadow_remove_all_shadows(d, page_to_mfn(page));
> }
>
> +/*
> + * Removes v->arch.paging.shadow.shadow_table[].
> + * Does all appropriate management/bookkeeping/refcounting/etc...
> + */
> +static void sh_detach_old_tables(struct vcpu *v)
> +{
> + struct domain *d = v->domain;
> + unsigned int i;
> +
> + ////
> + //// vcpu->arch.paging.shadow.shadow_table[]
> + ////
Honestly, I don't see what the point of this comment is at all. I'd
suggest just dropping it as you move the function, which avoids the need
to debate over C++ comments.
Preferably with this done, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
