Re: [PATCH v2 08/19] tools/xenstore: replace watch->relative_path with a prefix length

[Juergen Gross <jgross@xxxxxxxx>]

On 20.12.22 20:42, Julien Grall wrote:
> Hi Juergen,
>
> On 13/12/2022 16:00, Juergen Gross wrote:
> > @@ -313,19 +302,19 @@ const char *dump_state_watches(FILE *fp, struct 
> > connection *conn,
> >                      unsigned int conn_id)
> >   {
> >       const char *ret = NULL;
> > +    const char *watch_path;
> >       struct watch *watch;
> >       struct xs_state_watch sw;
> >       struct xs_state_record_header head;
> > -    const char *path;
> >       head.type = XS_STATE_TYPE_WATCH;
> >       list_for_each_entry(watch, &conn->watches, list) {
> >           head.length = sizeof(sw);
> > +        watch_path = get_watch_path(watch, watch->node);
> It is not clear to me why you call get_watch_path() earlier and also rename the 
> variable.
> I don't mind the new name, but it doesn't feel like it belongs to this patch as 
> the code in duymp_state_watches() would not be changed otherwise.
Both changes are the result of V1 of the series. Will undo them.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature