Re: [PATCH 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

[Chuck Zmudzinski <brchuckz@xxxxxxx>]

On 1/4/23 11:12 AM, Bernhard Beschow wrote:
> 
> 
> Am 4. Januar 2023 13:11:16 UTC schrieb Chuck Zmudzinski <brchuckz@xxxxxxx>:
>>On 1/4/2023 7:13 AM, Bernhard Beschow wrote:
>>> Am 4. Januar 2023 08:18:59 UTC schrieb Chuck Zmudzinski <brchuckz@xxxxxxx>:
>>> >On 1/3/2023 8:38 AM, Bernhard Beschow wrote:
>>> >>
>>> >>
>>> >> On Tue, Jan 3, 2023 at 2:17 PM Philippe Mathieu-Daudé 
>>> >> <philmd@xxxxxxxxxx> wrote:
>>> >>
>>> >>     Hi Chuck,
>>> >>
>>> >>     On 3/1/23 04:15, Chuck Zmudzinski wrote:
>>> >>     > On 1/2/23 4:34 PM, Bernhard Beschow wrote:
>>> >>     >> This series first renders TYPE_PIIX3_XEN_DEVICE redundant and 
>>> >> finally removes
>>> >>     >> it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make 
>>> >> Xen in the PC
>>> >>     >> machine agnostic to the precise southbridge being used. 2/ will 
>>> >> become
>>> >>     >> particularily interesting once PIIX4 becomes usable in the PC 
>>> >> machine, avoiding
>>> >>     >> the "Frankenstein" use of PIIX4_ACPI in PIIX3.
>>> >>     >>
>>> >>     >> Testing done:
>>> >>     >> None, because I don't know how to conduct this properly :(
>>> >>     >>
>>> >>     >> Based-on: <20221221170003.2929-1-shentey@xxxxxxxxx>
>>> >>     >>            "[PATCH v4 00/30] Consolidate PIIX south bridges"
>>> >>
>>> >>     This series is based on a previous series:
>>> >>     
>>> >> https://lore.kernel.org/qemu-devel/20221221170003.2929-1-shentey@xxxxxxxxx/
>>> >>     (which itself also is).
>>> >>
>>> >>     >> Bernhard Beschow (6):
>>> >>     >>    include/hw/xen/xen: Make xen_piix3_set_irq() generic and 
>>> >> rename it
>>> >>     >>    hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize()
>>> >>     >>    hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3
>>> >>     >>    hw/isa/piix: Avoid Xen-specific variant of piix_write_config()
>>> >>     >>    hw/isa/piix: Resolve redundant k->config_write assignments
>>> >>     >>    hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE
>>> >>     >>
>>> >>     >>   hw/i386/pc_piix.c             | 34 ++++++++++++++++--
>>> >>     >>   hw/i386/xen/xen-hvm.c         |  9 +++--
>>> >>     >>   hw/isa/piix.c                 | 66 
>>> >> +----------------------------------
>>> >>     >
>>> >>     > This file does not exist on the Qemu master branch.
>>> >>     > But hw/isa/piix3.c and hw/isa/piix4.c do exist.
>>> >>     >
>>> >>     > I tried renaming it from piix.c to piix3.c in the patch, but
>>> >>     > the patch set still does not apply cleanly on my tree.
>>> >>     >
>>> >>     > Is this patch set re-based against something other than
>>> >>     > the current master Qemu branch?
>>> >>     >
>>> >>     > I have a system that is suitable for testing this patch set, but
>>> >>     > I need guidance on how to apply it to the Qemu source tree.
>>> >>
>>> >>     You can ask Bernhard to publish a branch with the full work,
>>> >>
>>> >>
>>> >> Hi Chuck,
>>> >>
>>> >> ... or just visit 
>>> >> https://patchew.org/QEMU/20230102213504.14646-1-shentey@xxxxxxxxx/ . 
>>> >> There you'll find a git tag with a complete history and all instructions!
>>> >>
>>> >> Thanks for giving my series a test ride!
>>> >>
>>> >> Best regards,
>>> >> Bernhard
>>> >>
>>> >>     or apply each series locally. I use the b4 tool for that:
>>> >>     https://b4.docs.kernel.org/en/latest/installing.html
>>> >>
>>> >>     i.e.:
>>> >>
>>> >>     $ git checkout -b shentey_work
>>> >>     $ b4 am 20221120150550.63059-1-shentey@xxxxxxxxx
>>> >>     $ git am
>>> >>     
>>> >> ./v2_20221120_shentey_decouple_intx_to_lnkx_routing_from_south_bridges.mbx
>>> >>     $ b4 am 20221221170003.2929-1-shentey@xxxxxxxxx
>>> >>     $ git am
>>> >>     
>>> >> ./v4_20221221_shentey_this_series_consolidates_the_implementations_of_the_piix3_and_piix4_south.mbx
>>> >>     $ b4 am 20230102213504.14646-1-shentey@xxxxxxxxx
>>> >>     $ git am ./20230102_shentey_resolve_type_piix3_xen_device.mbx
>>> >>
>>> >>     Now the branch 'shentey_work' contains all the patches and you can 
>>> >> test.
>>> >>
>>> >>     Regards,
>>> >>
>>> >>     Phil.
>>> >>
>>> >
>>> >Hi Phil and Bernard,
>>> >
>>> >I tried applying these 3 patch series on top of the current qemu
>>> >master branch.
>>> >
>>> >Unfortunately, I saw a regression, so I can't give a tested-by tag yet.
>>>
>>> Hi Chuck,
>>>
>>> Thanks for your valuable test report! I think the culprit may be commit 
>>> https://lists.nongnu.org/archive/html/qemu-devel/2023-01/msg00102.html 
>>> where now 128 PIRQs are considered rather than four. I'll revisit my series 
>>> and will prepare a v2 in the next days. I think there is no need for 
>>> further testing v1.
>>>
>>> Thanks,
>>> Bernhard
>>
>>Hi Bernhard,
>>
>>Thanks for letting me know I do not need to test v1 further. I agree the
>>symptoms are that it is an IRQ problem - it looks like IRQs associated with
>>the emulated usb tablet device are not making it to the guest with the
>>patched v1 piix device on xen.
> 
> All PCI IRQs were routed to PCI slot 0. This should be fixed in v2 now.
> 
>>I will be looking for your v2 in coming days and try it out also!
> 
> Thank you! Here it is: 
> https://patchew.org/QEMU/20230104144437.27479-1-shentey@xxxxxxxxx/

That fixed it! I added my Tested-by tag to the last patch of v2:

[PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE

AFAICT, v2 is is ready to go!

Best regards,

Chuck