[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] tests: add G_GNUC_PRINTF for various functions
- To: Daniel P. Berrangé <berrange@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Thomas Huth <thuth@xxxxxxxxxx>
- Date: Thu, 29 Dec 2022 10:34:55 +0100
- Cc: "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, qemu-ppc@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Laurent Vivier <lvivier@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, virtio-fs@xxxxxxxxxx, Michael Roth <michael.roth@xxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, qemu-block@xxxxxxxxxx, Peter Maydell <peter.maydell@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Stefan Hajnoczi <stefanha@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>
- Delivery-date: Thu, 29 Dec 2022 09:35:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/12/2022 14.02, Daniel P. Berrangé wrote:
Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
tests/qtest/ahci-test.c | 3 +++
tests/qtest/arm-cpu-features.c | 1 +
tests/qtest/erst-test.c | 2 +-
tests/qtest/ide-test.c | 3 ++-
tests/qtest/ivshmem-test.c | 4 ++--
tests/qtest/libqmp.c | 2 +-
tests/qtest/libqos/libqos-pc.h | 6 ++++--
tests/qtest/libqos/libqos-spapr.h | 6 ++++--
tests/qtest/libqos/libqos.h | 6 ++++--
tests/qtest/libqos/virtio-9p.c | 1 +
tests/qtest/migration-helpers.h | 1 +
tests/qtest/rtas-test.c | 2 +-
tests/qtest/usb-hcd-uhci-test.c | 4 ++--
tests/unit/test-qmp-cmds.c | 13 +++++++++----
14 files changed, 36 insertions(+), 18 deletions(-)
...
diff --git a/tests/unit/test-qmp-cmds.c b/tests/unit/test-qmp-cmds.c
index 2373cd64cb..6d52b4e5d8 100644
--- a/tests/unit/test-qmp-cmds.c
+++ b/tests/unit/test-qmp-cmds.c
@@ -138,6 +138,7 @@ void qmp___org_qemu_x_command(__org_qemu_x_EnumList *a,
}
+G_GNUC_PRINTF(2, 3)
static QObject *do_qmp_dispatch(bool allow_oob, const char *template, ...)
{
va_list ap;
@@ -160,6 +161,7 @@ static QObject *do_qmp_dispatch(bool allow_oob, const char
*template, ...)
return ret;
}
+G_GNUC_PRINTF(3, 4)
static void do_qmp_dispatch_error(bool allow_oob, ErrorClass cls,
const char *template, ...)
{
@@ -269,7 +271,7 @@ static void test_dispatch_cmd_io(void)
static void test_dispatch_cmd_deprecated(void)
{
- const char *cmd = "{ 'execute': 'test-command-features1' }";
+ #define cmd "{ 'execute': 'test-command-features1' }"
QDict *ret;
That looks weird, why is this required?
Thomas
|
