[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 7/7] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 21 Dec 2022 11:19:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=em46XygaXAchgvGdscyI0MbzCrUgcFcQO4uP0WJYLBM=; b=RHrwTzLNpijufwicvL84Z/LsUOoPL1R7nXAB6ifUIGkE8cvjRY1Raus9Z63tednpJrCHc0ZkUhsXm8Tud6ptl2kQW0n4J3e2S/egSsXR9WBwqtMwPG22n/1TE0MfFwgEjVPfLnNTn77GwfoJ2RKxGA96iX7PS6KhHOSqvoLYTa+z1xEmz0/fVIOKhWXHFX3yUiAgkatmhb7zV2DHoR0cncaM6kWYrieUaA0v5R3sJg+Q9Yjt9DzKHQzwH3hbO6jCvYwVyUYvhg11H6iHFveUvXitFMXOzy/1AJkHvKmhqyHIvB1gtvYd/uT80+E62tygdW9aVdh230U+ksHXGICqYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=maBKna3Yn4HRurJWm2pCsZWEQ86E1nZB/W3O45aqUTLSaqINKypxP8G2Zp76wf4vr6PkgTEBrSSUsOTMLVP+kIVKSgmsLfmhAvScyPqbyRQ9YvdSdCVT1yP7QglubUwGfFQx9cnbruElSHuz7KlHOgOrKorSe9s8symsDZ9gCzxF8TrB+lsD3M4xOlu1gqNimcqVWTyf1ddhrP4MmM4jt13aUj/uEkcAwOnamQFMDKa+/mrDNtHa0TE9oIr/kbz/YxhG0Isv5sLYBp0f0HpgY+d2oKaVxHsUcMci/085pu7ZzHDhlFzYMQtikT5jeR515doSpKwYQvWWucUD0oYQ9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 21 Dec 2022 10:19:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.12.2022 07:34, Xenia Ragiadakou wrote:
> The function hvm_dpci_isairq_eoi() has no dependencies on VT-d driver code
> and can be moved from xen/drivers/passthrough/vtd/x86/hvm.c to
> xen/drivers/passthrough/x86/hvm.c.
>
> Remove the now empty xen/drivers/passthrough/vtd/x86/hvm.c.
>
> Since the funcion is hvm specific, move its declaration from xen/iommu.h
> to asm/hvm/io.h.
While everything else looks good here, I question this part: The function
is both HVM- and IOMMU-specific. However, by moving the definition ...
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
>
> I was not sure how to handle the copyright. I assume that I have to
> retain the copyright of Weidong Han <weidong.han@xxxxxxxxx>, right?
>
> xen/arch/x86/include/asm/hvm/io.h | 1 +
> xen/drivers/passthrough/vtd/x86/Makefile | 1 -
> xen/drivers/passthrough/vtd/x86/hvm.c | 64 ------------------------
> xen/drivers/passthrough/x86/hvm.c | 42 ++++++++++++++++
... here, you don't need a declaration anymore anyway - the function can
simply become static then, as its only caller lives in this very file.
Jan
|
