[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 09/18] xen: cppcheck: misra rule 20.7 deviation on kconfig.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 21 Dec 2022 09:54:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5TYP5fR+DfSoZAPCJIFgeX9gLs5R8o+vrRrS4kGk9cE=; b=nHn720Ai//GYNvqJC0bKFfnt1gINNfZ77eDyJuodEOikznnoBykaGZMt81rlKt+db5kF2IJ1sfxTDdSvYocpWEWzw/jC8YNVkbDSK/O8q7DBAZfe3P1pFZyeTz+lN4/vs2Fww5j0PMyJgkxQZGpnHagDoX7/uSClHEl/rx55+4LgHmnQv3Sj2aGZta4xSaXW/2satElIZx1Sk3Lp5FKiNSGG++NA4TWd6KTPfHiWnsf9zgUES9VbegSMuQixyEaTIvqcs75mxOhyDiuhBcdY26lQkN0CxYO1N/apOGD5Os4At8G5H0UYGiEto/zX5NjK5kU8FPtpbY70Ey2bXWl0Hw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l111vrGJLMhLDDZpUI+8FkXPYMgUxkOYdADINMOrCb8QRJ4FEdh/E3XOATXKlAxtbpN5JwU5tz1da22J8KN3VY19zYgi46/Lrb6X22UFRzB9SJBIqXvGslPjpKuqR2mv+q99EiNmmiO3slGIkf+vaSuzmP0fQnI9P78x33b1fKGjwpIsvhSKzKrLerNtWCUo9amdapBuTiSXVvPe0OarkB/++m5XAR5LDboAZPqHdj87tdWpX11DMONeY2MERq0umzTeCRSZh7UJ7/mUdtzAG5KjJufNdLqALIPnXTMQVARsItkwtkMF9xgKiYoBeaVLqAtFvAr/E5lyDV3RXJeDPA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 Dec 2022 09:55:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZFFBPeOWORFF7zU67S/8TUSweLK52h6oAgAGUD4A=
- Thread-topic: [RFC PATCH 09/18] xen: cppcheck: misra rule 20.7 deviation on kconfig.h
> On 20 Dec 2022, at 09:48, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 20.12.2022 09:50, Luca Fancellu wrote:
>> Cppcheck has found a violation of rule 20.7 for the macro
>> __config_enabled but the preprocessor branch where this macro is
>> defined should not be analysed by cppcheck when CPPCHECK macro is
>> defined, hence this is a false positive of the tool and we can
>> safely suppress the finding.
>
> So what was commit 43aa3f6e72d3's ("xen/build: Add cppcheck and
> cppcheck-html make rules") adjustment to the file about then?
Yes the commit is right, cppcheck itself needs that, the problem here
comes from the misra add-on (the cppcheck component that does the
MISRA analysis) that is wrong.
Anyway I will drop this patch together with all the false-positive on the
Tool for now.
>
> Jan
>
|
