[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction

To: Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Tue, 20 Dec 2022 20:18:19 +0000
Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
Delivery-date: Tue, 20 Dec 2022 20:18:24 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 13/12/2022 16:00, Juergen Gross wrote:

The accounting for the number of nodes of a domain in an active
transaction is not working correctly, as it allows to create arbitrary
number of nodes. The transaction will finally fail due to exceeding
the number of nodes quota, but before closing the transaction an
unprivileged guest could cause Xenstore to use a lot of memory.


As per the discussion in v1, the commit message needs to be reworded.

I will look at this patch in more details once I have reached the 2ndseries.


Cheers,

--
Julien Grall

References:
- [PATCH v2 00/19] tools/xenstore: do some cleanup and fixes
  - From: Juergen Gross
- [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction
  - From: Juergen Gross

Prev by Date: Re: [PATCH v2 10/19] tools/xenstore: change per-domain node accounting interface
Next by Date: [xen-unstable-smoke test] 175428: tolerable all pass - PUSHED
Previous by thread: [PATCH v2 11/19] tools/xenstore: don't allow creating too many nodes in a transaction
Next by thread: [PATCH v2 13/19] tools/xenstore: make domain_is_unprivileged() an inline function
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.