[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 08/18] xen: cppcheck: misra rule 20.7 deviation on init.h
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Dec 2022 10:44:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jn7b1slLY8wvu4lXcQuKb6YZeycbPJDIEKL82T3pcg4=; b=mOY/Q8QrsJM69o7qFA7xpIkmCHcldDDTDxmJLcgmSbtDUvoDOP3ODdeXf4Muz9DnOsYZ9MItu8hhcKjSAsWBrDK4W/QsCH1UbVD4B9tA5KsyZ/xvu1wVwiozwpP2arvmp80fO6EYwz8r4+ETcJ/H9s0nuRZlOCKxNenqEt2A2kVE3AG3uXRI23N9b0wP5sjBo74KgA46vRK3uawgT6EKhY4Arvnt3Y2x/AwufbT0ybIW8R+Uw837dsaaelln8TeAEbjCwNKGbZu1XOOpJL8F/1s7wWoHY0Fu160kEjI3hsHhrtMg4H4eBCs0NZ8W/UNNBQ27alkS4z6513rNtkIVCQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nRWjhcEhfsiD74TjaVbhClWEMdg46rXTy5p7TRJAj39A5Vi114gMMIChrisEDtXNTTB7r5p5h85fg1T0Vf6eeULH5zthqYRYNKwymYAYXvhKsHbO/hmh7kO5KbfJd3gRIkMjQ/cvQpY4eBpVId6rczkWE/eC9zEAUj73jHQrQyEz2TcCFdkiXUwzpVXsWyGslv45zZ6KGvPzDSpp4jve9zCpx356/gSYwsAbzzWTBhI8vrpkPjF+X7n4/PsVUzoV7nUVeIcZB8KamUMGgiaPC16h3NRZTQ4jMEKOvh2bTLDo7GswdWTkWVw1lFh8BliXh/X0sj6OoUkpQ/7egom+xw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Dec 2022 09:44:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.12.2022 09:50, Luca Fancellu wrote:
> --- a/xen/include/xen/init.h
> +++ b/xen/include/xen/init.h
> @@ -15,6 +15,7 @@
> #define __initconstrel __section(".init.rodata.rel")
> #define __exitdata __used_section(".exit.data")
> #define __initsetup __used_section(".init.setup")
> +/* SAF-1-false-positive-cppcheck R20.7 argument as text substitution */
> #define __init_call(lvl) __used_section(".initcall" lvl ".init")
Would cppcheck also complain about
#define __init_call(lvl) __used_section(".initcall" #lvl ".init")
? If not, removing the double quotes at the two invocation sites to
balance the addition of # here might be the better route here.
Jan
|
