[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 00/11] OCaml fixes
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Mon, 19 Dec 2022 10:54:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=taL+j06wqMXSj6LAwkRaMhAGjDlHIssZFXLkUhOyAnY=; b=OE80GOT917qsnLv2x75xuOsZFBodQY1N51siadahfTbHzPb5FPGlx86Rj+K/zSSLqAK30NYiOG9GzSu2hVses5VrQrQA92QOHMl7YhJp3dpBLK93Gsor/VXo7cHBkZ7P0jI5bAQc6OfQWF4hcMI9TQtFXZhtIDt6SVvraH6xNfc9eZbAFiZMGgaHyOsc4pha5uLxaiyxi+pjdzILk5D0eDawT8aOaYcdoA7cWFx52F07+ALgLPGUuPsO1RNyZ+k0qg4IzKwUaMFM9uwrJBNLuKHpXC5aDow/mMZK5WgyNTIPbjGx42mX65+6p2TOiwEMsknyiWnanJHiKZ/fB3WJyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MNqoqPJ1+vbWdW8BN7vAdZ0BZYKuml4To69FlnhFx110EHFZygc9Iql+c2o82AlPo686JV9SMTVIdxdGUiLE0QBGP5BUmGZoIDIU4bW53WHfMRnGKMAd6AfBI1f3lPzhn6eT1wAU1yKSTLplnHuvtP1FZoXej/VT7BayskmLJnnsTNR4wd5qAgqi8KWtWB1vM112BvsheVunqVgRBjfHUOPgMeVDMk8g48m2b1CWS1AEk7ujtfuQBzgvuMLsrKmHtx3yv8q17O41z/FruEbGMxVbjaVLLqzdpOpHrnufyYGR/EJatV5U0FrgAm8YRFqh++E+ZqrOmj/r6zq6ihFK7A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Edwin Török <edwin.torok@xxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 19 Dec 2022 10:54:53 +0000
- Ironport-data: A9a23:ZPZzT6PwvBIacRzvrR1ZlsFynXyQoLVcMsEvi/4bfWQNrUorhjBWx jNNWW7TOPyOMzb0ftpzbY2+phsOsZOExtNnTgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpC5w1mPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0tsqRlBQq OMbFBcmQT6z3+yz/72fF9A506zPLOGzVG8ekldJ6GiASNwAEdXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujaDpOBy+OGF3N79cdyQRN5Jn0+e4 GbH+Wj4DTkRNcCFyCrD+XWp7gPKtXOqAN9NSOLlnhJsqB6UxEEdFgc2bAG2r9zlrWDlWvEAc kNBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQruNA3Q3o20 UWOnPviATtyvPueTnf13rudsz6aIyUeKm4GIygeQmMt/N3LsIw1yBXVQb5LEqS4k9n0EjHY2 C2RoW41gLB7pcwW06S2+3jXjjTqoYLGJiYu/RneVG+h6gJ/Zaamapau5Fyd6uxPRLt1VXGEt XkA3sKYvOYHCMjUkDTXGbtdWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX XI/cDh5vPd7VEZGp4cuC25tI6zGFZTdKOk=
- Ironport-hdrordr: A9a23:70lDh6zKkuRmQdIVifKfKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEXvSRlRtCozhfEauXw1Y8zbwDq51DZcA
- Thread-topic: [PATCH v4 00/11] OCaml fixes
> On 16 Dec 2022, at 18:25, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
> From: Edwin Török <edwin.torok@xxxxxxxxx>
>
> Various OCaml fixes, some of which got Acked already.
>
> Edwin Török (11):
> tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper
> tools/ocaml/xenstored/Makefile: use ocamldep -sort for linking order
> CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
> tools/ocaml: run "make format"
> CODING-STYLE(tools/ocaml): add .editorconfig to clarify indentation
> uses spaces
> tools/ocaml: add .clang-format
> fixup! tools/ocaml/xenctrl: OCaml 5 support, fix use-after-free
> tools/ocaml/libs/mmap: mark mmap/munmap as blocking and raise
> Unix_error on failure
> tools/ocaml/libs/xb: check for unmapped ring before accessing it
> tools/ocaml/xenstored: validate config file before live update
> tools/ocaml/libs/xb: drop Xs_ring.write
I’m going to Ack this whole sale and provide individual comments.
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
|
