[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Mon, 19 Dec 2022 09:55:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DmlMZ+S8eBnIosfsYwNP+JbjxyIZJH/PcXWOIm+++2U=; b=TwcfK6q3bIPyZscr6r9fgUouxH7RjYCw3sD9NoCQxZksVf/mJt8oxATXlPpntozCN5fL5/qzJhQCre7oLxxpUQrOcJw6l3foHhonIK3eZZZzGkWCt4xXlis+4zUOkB5KZVOIgYNgKUqe0DGyBVUankhKsjwxglNBtKCWp4xaTU3kQHt7Oa2u9uhLPjxU0uakj13UHi/kw6X3PBMctj4GFoqVPI5/kqj/uG/opP/7XABckXSlNKiACs2esJAeM7uXbE8N8nrhAtrNyl2J9f5gmHVnE5zb8u7+oXdhHeJXsLF93JOELmJFxffTw0OkiH8vxWCt4CeJcSfI91njFXbstg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ROtlkjYI44ioXOG8mi4MlEuweXfI44s0Nmsu5NShylE9ksr/ADK+k3dTZ3KDq4Xofned9Yo6F9WGakUqgcEDwDdmTU2XxKZgRMQLoZsNQxg8a4xSPyiuyyevZX6TDfysvM2KcK8S4H8b0TqSAgB9BT3PrSdv2S4GNGI+oTdhO0WbDRListOxNJzzTRfWYs67h0cULT3fvMlr8WMG2Ixp6AkaPOjWJPF4lX5Ml1OG+SchzYix9LdDvPLOHN6UWr+a7fxfJ/E0N9nDTRqksS8zPWb5Re007WYzfYc4Pofju6zWKcGtd4BlaEDApCUWmt5VJcXMFC0lLnlv/IjOuVRhiA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 19 Dec 2022 09:56:10 +0000
- Ironport-data: A9a23:kRPWzKsFZ7hGA5NdXKjshkV6dOfnVHRfMUV32f8akzHdYApBsoF/q tZmKTyDa6mDYDH8Ltgnbd/g/UJVvMPQx4BkGVForyw2FigV+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QWHxiFMZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwDwAKNz68rNCK/o3qYPl+veUodMjKM9ZK0p1g5Wmx4fcOZ7nmGv+PyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osgf60b4C9lt+iHK25mm6Tp njH5Hj4CxdcMN2ZxTuK2nmtmvXOjWXwX4d6+LiQpq8y3gTPnzd75Bs+elW44uW91meFeNd8M WE6+S0T9bEO6xn+JjX6d1jiyJKehTYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ lOAgd7BHzFkt7yRD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ/i0zJR9M6Sqqt1ISqQ3f33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxod+51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:lhVcJal5iUiV6rc41SDtJ6FI3QDpDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuCQlGc1sRRx2xjIrLH4sJlON1GkcKp gmMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyYEUHoCbQBFrYGpe4/eIsrEYHtDRXe q1NdZfH+LjRFGebLp04w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEXvTBva48l/iNEOidUZ7DnUevq50/SIA
- Thread-topic: [PATCH v4 03/11] CODING_STYLE(tools/ocaml): add 'make format' and remove tabs
> On 16 Dec 2022, at 18:25, Edwin Török <edvin.torok@xxxxxxxxxx> wrote:
>
> See CODING_STYLE: Xen uses spaces, not tabs.
>
> * OCaml code:
>
> Using `ocp-indent` for now to just make minimal modifications in
> tabs vs spaces and get the right indentation.
> We can introduce `ocamlformat` later.
>
> * C stubs:
>
> just replace tabs with spaces now, using `indent` or `clang-format`
> would change code too much for 4.17.
>
> This avoids perpetuating a formatting style that is inconsistent with
> the rest of Xen, and that makes preparing and submitting patches more
> difficult (OCaml indentation tools usually only support spaces, not tabs).
>
> No functional change.
>
> Signed-off-by: Edwin Török <edvin.torok@xxxxxxxxxx>
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
I am in favour of automating the code formatting, and moving to OCamlformat in
particular. The main drawback is that it can make back porting more difficult
because formatting can change not just indentation but placement of parentheses
and similar grouping syntax as well, leading to changes between the current
code and older code that have to me resolved manually.
— C
|
