[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 01/11] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 16 Dec 2022 22:40:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GrMm7LbLeNO+jBdvmSUZ/XmWutnjRhifjOyhwJzR0Yg=; b=gzTGCMbiZNUV9A+WeUFcN/Yy5cY3cR4lm9XcShUOFK0vwi9BP8E13+p7TqiO3l/ROAryLRY8h0rxNgcOTlaiHpeMpBUjjz90i111inM2USs5GveHoTMHldArK+20aMOP3v3bH+2o81j60g4ukBn3K8cILy9IlH3Nbhdo/GL2NRf5RuPfGgOpyHmPs64zdA8XQmOh8UF7Na8KcDHReCDfiKrJ/IZkIHrkPyEMSSnw3ss+0nzr+z9zVrm+c/5uH1zSvvmc4NkYh9Mvp6V7GKWBgJ8Q9hXuZdtl5yhThQk8YmW8C2jtj5p2GRPTUet9FR3ke/b/CvgFX19I9id9Kppdqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f0itp1/Qwo59cxaKfFQVnYphlKfmFyTkDJwoY2NKE6yJ0RV1d3ESyaAO4sp30qASQhkutF6djsS9a/W/w4q7l6b5z8IiL2HcWUYIYvlt6ucIcqHAAit7ie3nlPFDoW16qSl5twg4UwGkRct75M993Ru3+PHrMh09sEg+8ur33h6apyN7JTBiU/P2h4qIK6nezL+uUf81536vggSKeWPROJcQxDlAnr3ET1wweONbhvL2tHDKNriKvHcAlI2OBoSve3S64DC24ia5sWzKcjo3E8Z5nvM93n6RxThEwmH66aZdQzJma4qeZIJ5cXFHR5Z2kpy+8NMYZ4UnV9OAM6myzA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 16 Dec 2022 22:40:44 +0000
- Ironport-data: A9a23:jaT+Qag3fyXrubplol42c4e6X161QBEKZh0ujC45NGQN5FlHY01je htvUWCDO63fM2vyeYwjadu+pkJSvMLVztQ3GQRoqC8xQ3kb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5gaAzyJ94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQqJ29RfwCmhdmE/5DrW7dJndwgDI7CadZ3VnFIlVk1DN4AaLWaGuDmwIEd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEuluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6RO3jqqUx2gT7Kmo7VCFGVGO3rOaFo2mGS8xYc kEYwxUrlP1nnKCsZpynN/Gim1aUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebTAjy FKhhd7iAj1r9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zvpd81hxeWF9J7Svfq0ZvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:Vaa5cKuLBKf5lfvgyvEn0sJD7skDS9V00zEX/kB9WHVpW+eTna mV7ZMmPHjP5Ar5OUtOpTnkAsK9qBznm6KdjbNxAV7BZniEhILYFuFfBOLZqlWLdhEWndQtt5 uIHZIObOHYPBxXitv7/Rn9M/tI+qjgzElwv5a680tQ
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZEXviniqeTfc5ckCqx5I7LdFfsa5xG80A
- Thread-topic: [PATCH v4 01/11] tools/ocaml/libs/{xb, mmap}: use Data_abstract_val wrapper
On 16/12/2022 6:25 pm, Edwin Török wrote:
> diff --git a/tools/ocaml/libs/mmap/mmap_stubs.h
> b/tools/ocaml/libs/mmap/mmap_stubs.h
> index 65e4239890..66f18d4406 100644
> --- a/tools/ocaml/libs/mmap/mmap_stubs.h
> +++ b/tools/ocaml/libs/mmap/mmap_stubs.h
> @@ -30,4 +30,8 @@ struct mmap_interface
> int len;
> };
>
> +#ifndef Data_abstract_val
> +#define Data_abstract_val(x) ((void*)(value*)(x))
((void *)(x))
I take it this has come from the Ocaml headers? The cast to (value *)
in the middle is entirely cancelled out.
Can be fixed on commit.
~Andrew
|
