[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 07/10] x86: Derive XEN_MSR_PAT from its individual entries


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 16 Dec 2022 08:52:27 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rjbZ6RRVHuf9/bWVPp8AKnmkvJ3C/V1DFCH7bMuoFPs=; b=OBj1j6fBgaa87WLjbeXp073LY/3tLbB/PIwyvrZpHjjHzC8tgMDJmR7CXLmrLFMPh6FwudKvjKNzeyPSQdyVyZIRADSSmdFHu73NCOg6aCEeSHuqNKEFGjJ6QFmt/bNrI2JXxxIQekygLI9vnTKDM5FuhnmeCxzaQlKS6r0tDjo5TdEfu6TTXDTs7dTL6xYI/30AKSUg+0lqyZEMcm48lkc9p2dsD0Aps2wcjgO/1kMw9s9cKAdd+WhA/kH5sKK/TZcc5XlIjdqMTBj0kpfF3TIt+D+6RUNFSLeGdSH6GDp1lgu0CTK3urF0jUEGIWsf1Fmppf2J+zh7G+booxH8nA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nhPWIGBjWIfnDnmhbaB21b71IDBMtx5mDfSiepNcEzYdzvExT+UXEZBpemN5mgG/CnTBVxPLzIhcUhaiiTeF53umFb9W2m3P/AIDoGnIwFxaiu+4nmtPLMeEgDuPkaxeluRhKroOuAK7ku5KBW/7gntDlxsBcJwtXc3fwF3YT58Ot5mKQNtPYHBet65zWUR6giS2Ql0TWAoOfTgn2ld9K3O7qy+JI4V77i48vosSR10EboHYAYTWbZ5W8AgXLH9tl4Mua5JCi/LQVldRlABPAoYjapMwDZyABkEBtNzHs79+qOV2lOpo50E/lDJ/yNjFcoQW+gqUF7gmiPvRkmzR+Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 16 Dec 2022 07:52:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.12.2022 00:57, Demi Marie Obenour wrote:
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -6357,6 +6357,15 @@ unsigned long get_upper_mfn_bound(void)
>      return min(max_mfn, 1UL << (paddr_bits - PAGE_SHIFT)) - 1;
>  }
>  
> +static void __init __maybe_unused build_assertions(void)
> +{
> +    /*
> +     * If this trips, live migration of PV guests to and from this Xen is
> +     * broken.
> +     */

As is anyone using in a hard-coded fashion what the public interface (xen.h)
says. This wants adding here imo. Then
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

> +    BUILD_BUG_ON(XEN_MSR_PAT != 0x050100070406ULL);
> +}
> +
>  /*
>   * Local variables:
>   * mode: C




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.