[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/12] x86: Add memory type constants
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 15 Dec 2022 09:49:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vlHe8xFggJqRRsM1weoTECRgK4E0qlYgV8VKRyxJB0E=; b=BeEBLp/gXdANPgkDgKzcQ+M2XKz96jwzHMxj9nTBqqTNiyhyIy3w7NXgPvEBQ1NdeVIcanykfBMZBIcq8tgGv6vKrsoNPedRTXmmtT2fpznAbV+pqJ/2OM4sl1devCXExh8waqLn3sCwS1F0g1I2JmXhaUhtigvxxBB5wajCY5LBL4d5UtF6/Xb08xCiPvfW8/O4WZ1zh3Z581+P6pZXLZ5w7p6g6zDIA+7T+YvTU9l3E0vfI9sEHs5Vx2NpfuP6y/lEkQWn5LOkrK8+c4EZ8aFt1lkZE8qYW+nHwHRzDyur5Kh2bzBvnWiGicSwOgR1m7pLR0q7jSqLURYm6VrONQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYAlu2jMIgkMmnonw+GuR8WDmNel/aNXNJYVC9xMzNheRstvpmDY/439r5RoQ62/lZDiizHZQeB/+SJ8q0pVQMQsLoKVjJIC3e79WkIMTzvt0SkzUwsb+7gjDrGkGivTlnDgpIMFU8l5OY3k9VuDnqYWbzYMYI3Yt5t+uaxxvEz27GVa1oTvUHSMXvVSZr000HvgNTf5NUT2alZI11voYY04Pi7gRCU3ox3t5kNfWr0mTVP4r0kSEs9SO0p/IwqVABQfB4TaoSAafaoaywuEyk5/osfDYp9T/uL3fHT5HETvMYta7sOLbshOfRpW5BM91Bt6Q0u1Me9xF8ERo8Ib0w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 15 Dec 2022 08:49:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.12.2022 00:11, Demi Marie Obenour wrote:
> --- a/xen/arch/x86/include/asm/x86-defns.h
> +++ b/xen/arch/x86/include/asm/x86-defns.h
> @@ -153,4 +153,15 @@
> (1u << X86_EXC_AC) | (1u << X86_EXC_CP) | \
> (1u << X86_EXC_VC) | (1u << X86_EXC_SX))
>
> +/* Memory types */
> +#define X86_MT_UC 0x00 /* uncachable */
> +#define X86_MT_WC 0x01 /* write-combined */
> +#define X86_MT_RESERVED_1 0x02 /* reserved */
> +#define X86_MT_RESERVED_2 0x03 /* reserved */
As said, unless there's a good reason to use 1 and 2 (and not e.g.
0 and 1), I'd prefer these to be numbered 2 and 3 to match the
values they expand to (and the numbering then not being as arbitrary).
Jan
|
