[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/arm: smmuv3: mark arm_smmu_disable_pasid __maybe_unused
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 14 Dec 2022 11:36:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YhpfXd8LVh0HhvYEWzdU5VwFs1BNznNeFJUckR9KOhY=; b=Ns5lRumGWTonyu7/MReAg+hM8Fe6itx8AHyHDfxb4nvDu3xQ1BcyUg3sPIgF8iGp9atmAE0jb6VskF0PTeOYwAieXtofKqNOsz7oDYz7j8HqvkaYIzYt04joL/6Ol3yHenr8IjHFFuGnRqDhFd8Jzxz+iQnLiai2huEWt/+6/J1Og4qX7OIGyogU603pV5Z6l/1Kf+5yFrmBgDsk+NbtFrgZbfAuI5mYw6xIFFpEf3NSWluJqFRxLMg2REJL/LRHtrAPwqK7ZfaofYYH7N56q+MW0Tqkr1f2Ze3DDkiBm7NsmxUSEWGcqJsU3nqfCaNKPPkChSUon4weQPY/GoLcig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixuxKDCt6VKtHIAfeSETJB+deNlvPmqCSlJXkdehBTXF+xcvAv80LGiMyuyYBB/B/PYtI+28qy57OdNLqxua0ZQH2N51mMlz2pbBj/61CBm5TRRv+xeYwAatKiTJrmSZoLnWWycicdP9CiFFxd9zenGC8BGuRoDZvX/iCPBqeVbmBdtX3h3A4Xp6o7ZhyAHIQZqMoWr6DCnLvgVJUDQiLP5dlgxzdtvFHNFfU4lDu31odaB2ZeIHfUgGqsd+ARm3C5HuOilYdGc9TRJRU6G1797pBKWvqO5gZfRPvBX5EaFv7QGf6X6k59RTMT5a0tg9xXBFsi7+8Uv0DvZIehiFHw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 14 Dec 2022 11:37:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZDx9yw/wEVo2DeEWwDI7Q4pTE1a5tQmYA
- Thread-topic: [PATCH v2] xen/arm: smmuv3: mark arm_smmu_disable_pasid __maybe_unused
Hi Stewart,
> On 13 Dec 2022, at 6:18 pm, Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
> wrote:
>
> When building with clang 12 and CONFIG_ARM_SMMU_V3=y, we observe the
> following build error:
>
> drivers/passthrough/arm/smmu-v3.c:1408:20: error: unused function
> 'arm_smmu_disable_pasid' [-Werror,-Wunused-function]
> static inline void arm_smmu_disable_pasid(struct arm_smmu_master *master) { }
> ^
>
> arm_smmu_disable_pasid is not currently called from anywhere in Xen, but
> it is inside a section of code guarded by CONFIG_PCI_ATS, which may be
> helpful in the future if the PASID feature is to be implemented. Add the
> attribute __maybe_unused to the function.
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
|
