[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/14] p2m-pt: Avoid hard-coding Xen's PAT
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Dec 2022 12:14:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oj2yZvdIO+hFPGZx/OLVEkuVaEkfKG9rEVa0u2i/1ec=; b=Qjc4o3EqHuT9EN2/0KltolnpsDMnJHp1z+yn9lrX25G2BlxTNNtdNAl/8UVDLxnFdwKqZN/gcyRYHxHVyufUXnVLh0CgkBwZYfAFY2LW9OwtimNhMCvbUzbyubDdA1x2yTub69gWkdAw2gQQ1AEjuxFG2DjfTDQNdpXICNNY7ziATPZYkv3QVRaHM8cpGEDcryVduMSwhiBX+XcnnXLJa4WnPYum4C7vM5kHZLRvWC8RgTtPxHh1ZN++7AhcSy1EEoKQsTyR9HmTD4gNHggdcmDa/dm3GtKhWo88rf2/SlHlQex3hmMnQjIoX5FE4evM5UFgoifNZc1svrPavMg7ig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uwmd5ATdoA2bdxQeqF9LEZ7/jN/8gWIFNIt1NrS80Sk3k7mrjFht/7JuHxbunIlY8fRr9bLG4KcwHxC9CGenJ8ao+L4FlE4JfGoVxJsgBk87gyOsPaNrJgoc0Npx9ToesKpOgfHj0Ob9P/PX4kVMRpFiJJC2EJBkERTWPvpX0tDfPUkiKK91WIMqCFL8a2A3ot2KMW7bLcXI+mES4hoUBu5t9YttSBjCkgEePzynJ3EHFS7dKf0c/YkNaf6F9RvBumnMwVndXuNDbDFE1dMislvCTzvmNSPnY9QVilaD0P4sg3UspTFwWaxLakPScN+dxdOvjOWQaGfz/hJXM4BoFA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Dec 2022 11:14:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.12.2022 23:26, Demi Marie Obenour wrote:
> This makes the code much easier to understand. No functional change
> intended. As per Andrew Cooper, the existing logic is incorrect, but
> this does not make it any worse.
>
> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
I'm inclined to suggest to prefix "incorrect" by "(now)", or say
"questionable" instead. This would give at least a vague hint at what
the problem really is (and that the code is merely stale, still
matching intentions we no longer have).
Jan
|
