[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V10 0/3] toolstack support for generic virtio devices on Arm
- To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 14 Dec 2022 10:43:36 +0000
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 14 Dec 2022 10:44:01 +0000
- Ironport-data: A9a23:KEQRVa5xy7tpKIQ5h4mR3QxRtD3AchMFZxGqfqrLsTDasY5as4F+v mdODWCGaPrZYzehfd52b4u1/UNU6JKGyoRrGwc4+S82Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKoS4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz OI6NR4KSTe5tsm2+oKpZdtFi8QkI5y+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJU0UUrsUIMtWcOOAj3/jczpeuRSNqLA++WT7xw1tyrn9dtHSf7RmQO0FwRzI+ DKapgwVBDkDN/OzkBnGqUi9pfHRpAmhQN8VSZSBo6sCbFq7mTVIVUx+uUGAiea9ol6zXZRYM UN80i8vrqV09EuvS9Tmdxm5pneeuVgbQdU4O+gz9AGMx7eS+wGYHGkJVBZFadovrshwTjsvv neLgtfoCDpHoLCTD3WH+d+8rzyoPjMOBXQffiJCRgwAi/HzrYd2gh/RQ9JLFK+uksazCTz2h TeQo0AWnKkeg8cN0OOg4VnNjjaop57IZh404gTRTiSu6QYRTIyvapGs6FPbxe1dN4vfRV6E1 FADn8Wd9/wfFpGlmymEQeFLF7asj96bMSfRml4pHIQk/i6F/3+ldJpXpjZkKy9BO8IJaXnjb UnVtA554J5VNWGtK6htbOqZENgwxLTnDpHpW+78acILZplqaBTB+CBobFSXmWf3nyAEj6A5M pqdbYCjEHcGFaN75D63Qe4H1vks3C9W+I/IbcmllVL9i+PYPSPLD+deWLeTUgwnxJqaghj79 PF4Dfqhyy9vQsLMSyTX9oFGeDjmMkMHLZzxrsVWcMuKLQxnBHwtBpft/F8xR2B2t/8Lz7mVp xlRTmcdkQOi3iOfdW1mf1g5MNvSsYBDQWXX1MDGFXKhwDAdbImm98/znLNnLOB8pISPIROZJ sTpmvls4NwVElwrGBxHN/ERSbCOkzz17T9ixwL/PFACk2dIHmQlAOPMcAr17zUpBSGqr8Y4q LDI/lqFHsJSGlo+UpiGOaPHI7aNUZ81wbIaYqc1CoMLJBWEHHZCdUQdccPb0+lTcE6el1N2J i6dAAsCpPmlnmPG2IChuExwlK/wS7EWNhMDTwHmAUOeaXGyEpyLndURD45lvFn1CAvJxUlVT b4OkK2sb6RczAwiXkgVO+8D8J/SLuDH/9dypjmI1l2SB7h3ItuM+kW74PQ=
- Ironport-hdrordr: A9a23:MNl/UKvGQ8mOc90ztJIBDWuH7skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Dec 14, 2022 at 02:04:56PM +0530, Viresh Kumar wrote:
> On 14-12-22, 09:21, Jan Beulich wrote:
> > On 14.12.2022 06:19, Viresh Kumar wrote:
> > > This patchset adds toolstack support for I2C, GPIO and generic virtio
> > > devices.
> > > This is inspired from the work done by Oleksandr for the Disk device.
> > >
> > > This is developed as part of Linaro's Project Stratos, where we are
> > > working
> > > towards Hypervisor agnostic Rust based backends [1].
> > >
> > > This is based of Xen's master branch.
> > >
> > > V9->V10:
> > > - Swap I2C/GPIO compatible strings, they were wrongly added earlier.
> > > - Arrange tags in timely order and add new ones.
> >
> > The affected patch surely needed all tags to be dropped which weren't
> > explicitly indicated to remain valid across the bug fix.
>
> Hmm, since it was a very small change (only fixed the compatible
> strings) I thought it would be okay to carry the tags and rather harsh
> to the reviewers to drop them, since they invested a lot of time
> reviewing these. Though I do get what you are suggesting here.
I would have carry over the tags as well in this case.
If the tag were dropped, it wouldn't really have been an issue for me,
it doesn't take much time to review a patch series that I've already
reviewed. I usually look at a diff with the previous version (with `git
range-diff`, patchew can help as well[1]), and my previous comment if
needed.
But dropping rvb tag of non-maintainer maybe more "harsh" as you says as
they may not have time to re-apply their tags before patch gets committed.
> Should I ask Oleksandr / Anthony to provide their tags for patch 1/3
> again ?
My tag is still valid. Thanks.
Cheers,
[1] https://patchew.org/Xen/cover.1670994930.git.viresh.kumar@xxxxxxxxxx/
Then look for "diff against: v9"
--
Anthony PERARD
|
