[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 1/3] xen/spinlock: add explicit non-recursive locking functions


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 14 Dec 2022 11:32:52 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cmt5gqVyJRkt4e6qAL0DVscfkdMb7JaZkWZ32j2x7Y0=; b=a0njlAPZOCbIYr8wtqMXw9QRBkVPwogS7kWQiyqDPZfnHzFuapfz7sL4fds3Xcbf17IsaH9r5aKlfhDLyExFclXdKJDhV3btIBxfhjNtuyiLmd7LOeTOTP0soJq0XXifKnEpn4fJboH3pckky6CX+5e6GmTy9EJf/mbGAabGXTPK6nlD1QOF5g9DDiNqNgyKldH5DXJGVd4ukCsieJYwdewRY6SVKzdu8lmVok1BrSt7TcDg+h3DmnBB2yQuo96l+rCyjd79KQzoMFqg9jzE5+anL20tusnfYwWtVAEI58opd5fMNyA+eQLUsh6GSmbUc5Xz9ktveLgx49htoKafmw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQPZX4TyzvXJIpzxUn0ChCpaP2FL5/0S1ik1Ght3Ttkp3pWqFM02q6KX3nUfgTcrVW2ii3T6ks/rzuxGGHjXfnouxG3r476F1qJvvvaArDZrnfEqgc/kqqJLv8NaO2sPXDFcOf2oqrGCtEjmvQ+hYAvTWS4BNjE67dO7GuuT2oM4Yq+EuqThwbLtJvv8WfyuSBJiCbGFE+A0K0vgUIfLzeXKUZ/QfxggJwb0xQxoWy+fHLalaxfBnkIlOQNj7CiBdQm+g4QaEr4GT4RUnfAAp2jUWcaXG13XAf5tjP+AwNs8Pyymg61RvjhuU6GqLnAtrMTwUyYWkBLWB5yvrF13kw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Lukasz Hawrylko <lukasz@xxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 14 Dec 2022 10:33:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.12.2022 11:21, Jan Beulich wrote:
> On 10.09.2022 17:49, Juergen Gross wrote:
>> In order to prepare a type-safe recursive spinlock structure, add
>> explicitly non-recursive locking functions to be used for non-recursive
>> locking of spinlocks, which are use recursively, too.
> 
> While I can see that something needs doing, a function name like
> spin_unlock_nonrecursive_irqrestore() is really unwieldy, imo.

While further looking at patch 2 - how about rspinlock_t and rspin_lock()
etc, and then nrspin_lock() etc here?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.