[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/19] tools/xenstore: let talloc_free() preserve errno


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 14 Dec 2022 10:54:49 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=glOYJ+UpQVslLNTGc1Qxkq2UXXHNyE0lNYIpA7VEbZ0=; b=AQ9sZxHc5JK6yyLKkfMqtvYv0q/EeE49ufvCdYPHhwKlwK/9iEEmtK9bESDVI4q6DrEX+muiknywkGL8hN/DAypa7ThizlEK4Qtbec71TKnDwH1sxT7pwUGKLXhZFI4+e0xx7jxSr3mfc0lSuWveBYQ6HDXtyaRlnoPEtQwQN6pL8/jVoH2h6TgVKBSYBqQf11lTn/nl679wStQXftcuvu1xijSw8U5hAhqSInyuR1BD3hODe2IMYBlrRethtLNckku8KLewRXQgjQf1bB5O81jgIbjikrUSCy0PLdCGvAqGxokIg81nF6EqIVZVCQyKXBKHRawub6GH+YVmCfL9bg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQ/eW7KNnKboG3D/j2lHPtL1vCMkPukXlQMh9pZ9ebN0cLEb/4qnfYTc9LdI2WvQ6lR8FDVPpvdmmpE51Qm0INH2ZbrnpUGNGm7kqjs2Zk4oYCrr1nUJ/Bqb/F6mbSxSQ3KxMHAvIkxt1aDPq3EyCNzJa92IB+zHIj0nCj1jgHnyKknXTOaF01XfIKfP8jK395WW6MvqIHOhvbKH4JHH2HfRvTob00gYAqRjKui8KlZnndrRUfIK+p12fOsryuiGthZ3PbHrEC2DUpVbOOvicVB0oNqCE4C9wDkxiwCCI15zN6xgJyEjJgzVq4PPVvxztB5obs1NNKHf3n7rLoPy6g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 14 Dec 2022 09:55:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.12.2022 17:00, Juergen Gross wrote:
> Today talloc_free() is not guaranteed to preserve errno, especially in
> case a custom destructor is being used.
> 
> Change that by renaming talloc_free() to _talloc_free() in talloc.c and
> adding a wrapper to talloc.c.

This looks to be stale ...

> This allows to remove some errno saving outside of talloc.c.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V2:
> - drop wrapper (Julien Grall)

... after this change?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.