[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 05/18] xen/arm: Clean-up the memory layout


  • To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Tue, 13 Dec 2022 12:00:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jk5wOyOTt+uxgrFJolwdZrWgJ2UIB8HAi3os42RQM/w=; b=nfBehRA10WmGg/MmrEhTUkckgb/yLY/Y1rrBBKlv8BX/7NEw85tNSRSRI/YczR9G8iB4lfdul/cALq8K1gL0FDQrteYijeHdJNsOlZ3DLKK+dTzKQtnNvFPnv15IyYn2jqOV5LcO6hQtY9puns1WrkE62PvhnL+qB4C7lv0+jKdk6AGzqA5OL1Q88/3/LRBk8owFez3JwgIM7muurOXrqx11lkPdc095x1w68CizxwvaUHMYPxxypA61vmXk0c5O/OcKmwyJe+b0VvzDyyXzO6sDebEKRym86ZTipZarqGEOHM0kmc60pTJTDOfCZY90nNTIcrd5nBEgvyew7Qxy6w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/00ESfNWx9ibvKXw+M4aEnwjayzRcT2OUBNHyKMnHQs5OPZ5ZmZ5RjY9h5XSVsQmcr9r3vWGW5yZ+tdSE9FqnTHO7VUz2Uu9p51mD15xQU07gzxDAaILsrcVyu/xdgxqVjCgxWGeahoZqBYAFQiQDxdYrsnPcFioccSCnDU7/O8PyWtvezTZ9x59jpJ2I46QU37P4hC/PK1O2z1WvUvvcNv3pZiDRFnSAbiqoz0MY89avSy26x4q+Xk32HJOBmJIzwyLM2WhNfSkt5MB/Kg1PcEUcPSjlgNuKr7lmoh4QVQMjmFkjqxAAf7aVgiQDCtLpaCmts9X8s/zvYj8cuMEQ==
  • Cc: <Luca.Fancellu@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 13 Dec 2022 11:01:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 13/12/2022 11:57, Michal Orzel wrote:
> 
> 
> Hi Julien,
> 
> On 12/12/2022 10:55, Julien Grall wrote:
>>
>>
>> From: Julien Grall <jgrall@xxxxxxxxxx>
>>
>> In a follow-up patch, the base address for the common mappings will
>> vary between arm32 and arm64. To avoid any duplication, define
>> every mapping in the common region from the previous one.
>>
>> Take the opportunity to:
>>     * add missing *_SIZE for FIXMAP_VIRT_* and XEN_VIRT_*
>>     * switch to MB()/GB() to be avoid hexadecimal (easier to read)
I forgot about this one:
NIT: s/to be/to/

>>
>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> 
> ~Michal
> 
> 

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.