Re: [PATCH 15/20] tools/xenstore: make domain_is_unprivileged() an inline function

[Julien Grall <julien@xxxxxxx>]

Hi,

On 13/12/2022 07:57, Juergen Gross wrote:
> On 01.12.22 23:05, Julien Grall wrote:
> > Hi Juergen,
> >
> > On 01/11/2022 15:28, Juergen Gross wrote:
> > > clang is complaining about a NULL dereference for constructs like:
> > >
> > >    domain_is_unprivileged(conn) ? conn->in : NULL
> > I have just build xenstored with clang 11 and didn't get a complain. 
> > So can you provide more details?
> It was reported by Edwin during development of the XSA series:
>
> On 11/08/2022 19:01, Edwin Torok wrote:
>  > xenstored_watch.c:152:39: warning: Access to field 'in' results in a 
> dereference of a null pointer (loaded from variable 'conn') 
> [core.NullDereference]
>  >          req = domain_is_unprivileged(conn) ? conn->in : NULL;
>  >                                               ^~~~~~~~
>  > 1 warning generated.
>  >
>  > clang 14 says this is a NULL dereference ...
>
> You even responded to that report, BTW.
I respond to a lot of e-mails and don't necessarily remember all of them 
:). That's why we have commit message.
In this case, you want to mention the compiler version in the commit 
message.
With that:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall