[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/20] tools/xenstore: move changed domain handling



On 13.12.22 07:53, Juergen Gross wrote:
On 01.12.22 22:58, Julien Grall wrote:
Hi Juergen,

On 01/11/2022 15:28, Juergen Gross wrote:
  static bool check_indexes(XENSTORE_RING_IDX cons, XENSTORE_RING_IDX prod)
@@ -492,8 +504,12 @@ static struct domain *find_or_alloc_existing_domain(unsigned int domid)
      xc_dominfo_t dominfo;
      domain = find_domain_struct(domid);
-    if (!domain && get_domain_info(domid, &dominfo))
-        domain = alloc_domain(NULL, domid);
+    if (!domain) {
+        if (!get_domain_info(domid, &dominfo))
+            errno = ENOENT;
+        else
+            domain = alloc_domain(NULL, domid);
+    }

I don't understand how this change is related to this commit.

It is directly related to the hunk below. Returning errno in
acc_add_dom_nbentry() requires it to be set correctly in
find_or_alloc_existing_domain().

Wait, that was nonsense. This change is probably a leftover of a
previous version. Will remove it.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.