[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/20] tools/xenstore: replace watch->relative_path with a prefix length



On 01.12.22 22:51, Julien Grall wrote:
Hi Juergen,

On 01/11/2022 15:28, Juergen Gross wrote:
@@ -324,8 +312,7 @@ const char *dump_state_watches(FILE *fp, struct connection *conn,
          head.length = sizeof(sw);
          sw.conn_id = conn_id;
-        path = get_watch_path(watch, watch->node);
-        sw.path_length = strlen(path) + 1;
+        sw.path_length = strlen(watch->node + watch->prefix_len) + 1;

Why are you open-coding get_watch_path()?

Will fix it.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.