[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libxl: abort on memory allocation errors


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Mon, 12 Dec 2022 11:37:41 +0000
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Mon, 12 Dec 2022 11:37:57 +0000
  • Ironport-data: A9a23:Wd1RZajj/fQMyBzIOiUgVfCoX161ShAKZh0ujC45NGQN5FlHY01je htvUDuBPqrZYDGgfogjb4zn804CscLXnNMwQAQ9ry0xRX8b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmUpH1QMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWs0N8klgZmP6oS5gaEzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQZcHMrZC+8td652bGGRbdgluMsIOz0adZ3VnFIlVk1DN4jSJHHBa7L+cVZzHE7gcUm8fT2P pRDL2A1NVKZPkMJagx/5JEWxY9EglH2dSFYr1SE47I6+WHJwCR60aT3McqTcduPLSlQthbH9 j2WpzWoav0cHOKx6R/YtTWjuuvogx/pQ4IfGJ+b0Mc/1TV/wURMUUZLBDNXu8KRlUqWS99Zb UsO9UIGr6co81ewZsLgRBD+q3mB1jYZUsBVGvc36ymMzLTV+AeTAmUYTj9HZ8civcVwTjsvv neZktWsCTFxvbm9TXOG6qzSvT60ITISL2IJeWkDVwRt3jX4iNht1FSVFI8lSfPryI2ucd3t/ 9yUhClmxJMZsvE566qi/m3I3T68gZfFaxFgs207QVmZxg9+YYekYamh5l7a8etMIe6lc7WRg JQXs5PAtb5TVPlhgATIGbxQR+/xu55pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgarrUKzGLoC6T7wJs8w4ifIQCqWdjCfdoElTibe4hggBanQEn6AlI ou8es2xF3scAqkP5GPoGL9CgeR2mHBllTK7qXXHI/OPiOr2WZJoYe1dbAvmgh4Rs8toXzk5A /4AbpDXmn2zocX1YzXN8J57ELz5BSFTOHwCkOQOLrTrClM/SAkc5wr5netJl3pNw/4EyY8lP xiVBidl9bYIrSSedFXSMCE/Nu2HsFQWhStTABHA9G2AgxALCbtDJo9GH3frVdHLLNBe8MM=
  • Ironport-hdrordr: A9a23:Xz1vIaOULwV38MBcTnqjsMiBIKoaSvp037Dk7SFMoHtuA6qlfq GV7ZMmPHrP4gr5N0tMpTntAsW9qDbnhP1ICWd4B8bfYOCkghrUEGlahbGSvAEIYheOiNK1t5 0BT0EOMqyVMbEgt7eC3ODQKb9Jq+VvsprY59s2qU0DcegAUdAE0+4WMGim+2RNNXh7LKt8Op qAx9ZN4wGtcW4Qaa2AdwM4dtmGid3XtY7sJSULDR4/6AWIkFqTmcXHOind8BcCci9FhYwv+2 jdkwD/++GKvvyhxgXHvlWjn6h+qZ/OysZjGMfJsMQTJzn24zzYHLhcZw==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Sun, Dec 11, 2022 at 06:59:49PM +0100, Marek Marczykowski-Górecki wrote:
> Use abort() instead of just _exit() in libxl__alloc_failed(). This
> is more friendly for debugging, as it will trap into debugger,
> systemd-coredump will collect coredump/backtrace etc. It's much more
> useful than just "libxl: FATAL ERROR: memory allocation failure (...)"
> message without context where it actually failed.
> 
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.