[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2-ish] x86/boot: Relocate Xen using memcpy() directly
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 12 Dec 2022 11:16:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4jbGHzMBvgmBaiIv9+VXOj2aJ1FlY6Hs46cyEtiVHGw=; b=mb61noCxPkFHaU301Xu0yB/pZtTOpYVmVhfdkWpVwlLJpNnkitH6CDuVa7xV6VvSlGEVkGURCDqZY0lRMlg0nKLvX7tBsbIOjXzGUpPjOrTFLvRPD1hNviaocDbkVZXWtOQS13ufOq7RRC/Nzq8SdOYInRK67Mnc8kN6s6K+UWynj+haylVAusw0T85eGwa6AmhrTw3ay2ajqXVd+gNu5JUqzfZu73z9fTUxaj3Ztf9yDL7nMZoRfAc929g8T8fSYNTchtb3Bnju1pe4TZ08GFoBUD0Hc+9cArUnQ58VtpDe6XvxXluq0lHgz+rA1MQl+jwQ2ickK0IqkJhDa4YHiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXtCbDWF74U8a+PJiygDePglcU8ObDgULISazoubdZDCJOHvCb6SYqVaJzvWdGGuSzs5noadR4wIyZYnDOQ8BFnLcD7xvsWxqrvrpuKjIcOsCk8e0PldRTtCKs8T9rw3xhORyApJEg14VYVF8pbUtIJLh43cJohjnHWqb1UD4g7rkfyM/yR99C//+EUmHFvG11kDn4QeeixuMNoRwr498Sr+Xyvpj+jef05SU6U7QkAhL+rj0CPRjx/m8TgLL8Q51aU+D1EhxfKggBOv9zQCsRW00019iDmomeMhaNp2v+/N1Z102fdb5WGGmi7WJ7gCdmx3hPjtt0m4oIfIp48qvw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 12 Dec 2022 10:16:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.12.2022 22:42, Andrew Cooper wrote:
> We can relocate Xen by reading out of the virtual mapping that we're executing
> on, and write directly into the directmap. In fact, this removes one
> dependency on Xen being "at 0" (the XEN_IMG_OFFSET passed as src) for
> relocation to occur.
>
> This removes all the temporary pagetable handling under the covers of
> move_memory(), and results in a forward copy rather than a chunked backwards
> copy (caused by move_memory() always constructing src and dst in a way to
> trigger memmove() to copy backwards).
>
> With the penultimate caller of move_memory() dropped, clean up the API. Drop
> the keep boolean, folding in 0 from the final caller, and drop the return
> address which has been unused since c/s 0b76ce20de85 ("x86/setup: don't
> relocate the VGA hole.") in 2007.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
