[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] docs/process: branching-checklist: Update it


  • To: Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 12 Dec 2022 10:56:26 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PJj15GFvXZeFxUlDRJPYmS7rYjtIilbGR//bfKeTn2s=; b=cbXoxX5rPB/yNF49BoQzxhF+8xJOjjcPfOPPEQplfyIGTq+5dmXslAZPDdrZXF7dlVCrO5c5C0+OK+bETlTBAPVco/GGuMYoV1q/twS4nvtjKU74do5rM2KD27PECB4lWcBvL1l+9g6AnaVdCpTnj/qHgnwVrzx44P76VxYpAhWUO/o8ZGhofGu420RmX83CuSHKKWxjVTcPf529O6K1lDUlKS14zdgIXMrfL0zK7Jb+grd9dhi/ccwIMoqvS+z20HEmTJSzZuyehM7GoK3zkHz2Blz/OfDrBHt1spLZFYzliBkMrg4ci2z4Ltcznw9ohWwTIAeHWMr2BpeLH9KHqQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NiTG28SA1CoGbHTzDgnX4RjomRWK5A2JjPGLLv3zyHddlUFHjL52EQn47XQyfsB58daPUNx+miRAJHNQ59ZkfmRWH9a32rXt8rSynq246PGNP5z52JT8INOTCjguQSBVf8EcEiVdSfReiCwTDBBpxK0jw3+j/e8Iy9lA57uN4Rtx2s3LmejMOobL9+WpY802a1XHPlxeZLmbhCSzbzgks5CQlBKJycqJKifJ2P5kuVwR0OTxuOkjY6kjSgR6r3+oB8piQfWni3/m1h2rqcPXIJ2FNLzULHe1nRVlcTSOX8f1YUom0qtharDJzfauJddu+/zBEPy8B1iO/mgmWUnGAQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "ijackson@xxxxxxxxxxxxxxxxxxxxxx" <ijackson@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 12 Dec 2022 10:05:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.12.2022 10:49, Henry Wang wrote:
>> -----Original Message-----
>> From: Julien Grall <julien@xxxxxxx>
>> Subject: [PATCH 0/8] docs/process: branching-checklist: Update it
>>
>> From: Julien Grall <jgrall@xxxxxxxxxx>
>>
>> This is a collection of improvement for the branching checklist.
> 
> Thanks for this work! Since from the docs/process/RUBRIC we are having:
> ```
> They are living documents, and no special approval is needed to modify
> them beyond the usual acks for commit.  They should be updated as and
> when it seems expediant.
> ```
> 
> I don't know if my reviewed-by counts but I did go through the whole
> series, so for the whole series:
> 
> Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>

Why should it not count? Thanks for taking the time to look through
this series.

>> Julien Grall (8):
>>   docs/process: branching-checklist: Use consistent indentation
>>   docs/process: branching-checklist: Remove reference to qemu-ijw.git
>>   docs/process: branching-checklist: Remove reference to root
>>   docs/process: branching-checklist: Clarify steps to add the branch in
>>     osstest
>>   docs/process: branching-checklist: Reword the section about Config.mk
>>   docs/process: branching-checklist: Remove section about the cambridge
>>     colo
>>   docs/proces: branching-checklist: Update the section "add to patchbot"

Just one nit here: The subject prefix could do with adding the missing 's'.

Jan

>>   docs/process: branching-checklist: Add a list of accounts at the
>>     beginning
>>
>>  docs/process/branching-checklist.txt | 122 +++++++++++++--------------
>>  1 file changed, 60 insertions(+), 62 deletions(-)




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.