[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] xen: domain-tracked allocations, and fault injection



Hi Andrew,

On 23/12/2020 16:34, Andrew Cooper wrote:
This was not the christmas hacking project that I was planning to do, but it
has had some exciting results.

After some discussion on an earlier thread, Tamas has successfully got fuzzing
of Xen working via kfx, and this series is a prototype for providing better
testing infrastructure.

And to prove a point, this series has already found a memory leak in ARM's
dom0less smoke test.

You mention this series recently on the ML. So I decided to give a try and manage to reproduce your "memory leak".

I put it in quote because the problem is not Arm and instead your code. If you look at the implementation of _dzalloc() you are using _xmalloc(). So the memory is not guaranteed to be zeroed after been allocation.

This is breaking the expectation of the callers. What you want is using "_xzalloc()'.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.