[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] x86/tboot: actually wipe contexts


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Fri, 9 Dec 2022 21:53:37 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0G7xtXDmQrZVS8Nn3WlErlZeN4nTWCBXKB+0GtUuEc4=; b=Ku+/pABZSuAUgeiz6L3NLrFk+IfCKzYGppmNB/gD38RAeq+LjAjLUh7jEOygF85rhtRixGOnnssqmjz1hTWX4C4bhzP/ftdtUj2WjMLi+aJP7Iw8bjyCbg9iWS5xfPqVTJ0o4YLRED30eiuDowLNhhulkb489OnP8BVR5lZWtOiq6npXx5sEYTNgsytmWSemXvekCXaXteZTwRFG4ko8b5k2HlgOc63DPXEShEfRVkMX2rqem5Ml2xZTaFMfM8VX0GENY07C7XR4qiKb292ZYBaeKI0RvZpw7/brF914toKefrQUI0/s7B59uqYjnkIqFw/iI6OCrvDiDVCtcaL+2A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5Qo/NgV3Xd+iIPNcfKc4fDQ/Kd2j4xgMyRKo8d4VAkK3EH6EAJ/arbx+DQXtvv9toov6mcb0ww3EKI9zypPdyab13W0rKAAUt15zTJ0NQTTHd+Lq4nsS+xmx/1Pax1+oxQioyPZnHddz0vicmW3nWSJiteJC66BRogiwF/22CgnQSDQGEPfh83KMqFE1Jmz/5/NnoSq4fvzvHhgG3SSg0LDPDG308Sy8cFMJQGlqZy2Dp7Q7riWsBSklMV4lnoPunhqWqn05hUeV6xXix0lwtXNqT6wMyx4FgcJsTm8AfkZHiZO/CfgVcGaf4nHdtTWy+DoP4weR6z+H1jeVGufJA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Lukasz Hawrylko <lukasz@xxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Mateusz Mówka <mateusz.mowka@xxxxxxxxx>
  • Delivery-date: Fri, 09 Dec 2022 21:53:48 +0000
  • Ironport-data: A9a23:uAOi5aJxVGGIqBrVFE+RJpQlxSXFcZb7ZxGr2PjKsXjdYENS0DAOm GBOCzqOa67bYTb0KdwnaN/j9UhTv5TSnNBlHgFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPdwP9TlK6q4mlB5ARvPasjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c51J0pB9 +IkcAkcYx2D19KI+K7lCcRj05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzX2lAttCTO3QGvhCr3eYlysREEEsVXi2mP2zr2iFcO5NN BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9UQARMGwLfj0sTQIa+cjno4Z1lhanZtp7C6u0kt3dECn92 SyXtzM5g6gPjMkNzOOw+lWvqzelupXUVRxz4wLIXWuN7wVlaYrjbIutgWU39t5FJYedC1OH7 H4NnpHH6PhUVM/c0iuQXO8KAbeloe6fNyHRikJuGJ9n8Cmx/3mkfsZb5zQWyFpVD/vosATBO Cf70T69LrcIVJd2Rcebu76MNvk=
  • Ironport-hdrordr: A9a23:3ZmKLaDAU0843ZjlHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHZCXqrQyWSF53TrEGtcF2dIG8p2a5mHmsA
  • Thread-topic: [PATCH 5/5] x86/tboot: actually wipe contexts

On 06/12/2022 13:57, Jan Beulich wrote:
> Especially with our use of __builtin_memset() to implement memset() the
> compiler is free to eliminate instances when it can prove that the
> affected object is dead. Introduce a small helper function accompanying
> the memset() with a construct forcing the compiler to retain the
> clearing of (stack) memory.
>
> Fixes: c021c95498d9 ("x86: Replace our own specialised versions of memset and 
> memcpy with")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks.  I'd noticed this before wanted to do something about it.

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.