[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] x86/mm: PGC_shadowed_pt is used by shadow code only
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 9 Dec 2022 21:48:06 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUgU4yRuYSoG/+a4ZiHw46MHbVaRO4LNmBcBeohLDL8=; b=Vv/ezyjf1lhNvQ0Qy3Zh0xw6FYkee5mTHQS+6CoC+EZQq5dgz3ZcA1Ik/Zt2DPmxeIK7QILqHNyygmKmDcuJsjXLTT35asTGVj0chIrRunOR4jppPe40RLt5I655Zb9WZg76ZIhAUbOFXljfE2esmwaCMhkifM4K9SsXcSOo2dCLLKreehYFqXFO40TT6t9FD+h4ByC0WLgWlmP2CzkqqAMaacXFlYklQNRpbe806AcUbOMqNZ/bf08MBWD32PD6moCIoTL9ziVf9/YjJCpGbAQLpy4bUiMt/EDbZws6SBEcAn3SK3B8cuSlEVFYvEbm8B2dT97LJ+SXXBZoyJaTIw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xh57pbHMfKKBIfHUacuhiO8JG23sXv2KZCOWyGL+LGobddmM8KyOEvEkCjY4wwNGihEZix/b/y6GO+TeUjSKvaKF5zFHbcmCUHlzFiKjT79ikgDHLbXrA/ULDJPCMg1WRvAdeCzKlPwl0KjIWqkwITaTA29l1pi5xymBcrYcOku9C2tQK9o/QCvt+rwK2LIk0lotj+JBH7OS9t3kXFzXlF/VVoTOsGdfAKfSSr4SL1sI+ji/bDxaHQdy7m/eqBq3fBJFtH+pf4ZbrlyRds5Fy+E/5+XRwj37TgonubT/qrrWjvxlCDmUIp8fhzxy5jjrWVoYH6va9gwLxzuPEtAEpQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 09 Dec 2022 21:48:25 +0000
- Ironport-data: A9a23:lZQzs63JtN60bP2dmvbD5fFwkn2cJEfYwER7XKvMYLTBsI5bpzQGz DROXzzVOqyONjagKIt/PITk9U4FscSAxoUxTQBlpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK5ULSfUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS9nuDgNyo4GlC5wZmNKgQ1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfWDpHq 6IAGR00cxmtv7iG7KC/FLNpr5F2RCXrFNt3VnBI6xj8VK9ja7aTBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxqsy6Kkl0ZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXKjAdhNRe3onhJsqAytl145LgU7aV6Eg+PikUixAdRNe 3VBr0LCqoB3riRHVOLVXRe1vXqFtR40QMdLHqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9Vna15rqS6zSoNkAowXQqYCYFSU4P5YnlqYRq1xbXFI89Qeiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAszA3Md4owF6lc2S8
- Ironport-hdrordr: A9a23:TFfrSaA0cTaFkmvlHej1sseALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuaKdkrNhR4tKOzOW91dATbsSoLcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUeF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlil9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4sow3TX+0SVjbZaKvm/VQMO0aaSAZER4Z /xSiIbToFOArXqDziISFXWqlHdOX0VmgLfIBej8AfeSIrCNXMH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59as5Xxa/ptVFZ9l/1owKpuKuZIIAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkdoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWtKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEniefvFmHKc7hiwlbF/NLggFkPsulqSRkoeMNIbDIGmEVE0kldemrrEWHtDbMs zDTa5rPw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZCXpM2cQpccRTS0mqJcKyQ1lQz65mHOGA
- Thread-topic: [PATCH 3/5] x86/mm: PGC_shadowed_pt is used by shadow code only
On 06/12/2022 13:54, Jan Beulich wrote:
> By defining the constant to zero when !SHADOW_PAGING we give compilers
> the chance to eliminate a little more dead code elsewhere in the tree.
> Plus, as a minor benefit, the general reference count can be one bit
> wider. (To simplify things, have PGC_shadowed_pt change places with
> PGC_extra.)
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Coverity is going to complain some more. I've still not figured out a
way to get it to ignore "AND with something that's
compile-time-conditionally-0", but we have this pattern elsewhere.
~Andrew
|
