Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

[Julien Grall <julien@xxxxxxx>]

Hi,

On 08/12/2022 08:53, Henry Wang wrote:
> > -----Original Message-----
> > From: Jan Beulich <jbeulich@xxxxxxxx>
> > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT
> >
> > On 07.12.2022 23:42, Demi Marie Obenour wrote:
> > > A previous patch tried to get Linux to use the ESRT under Xen if it is
> > > in memory of type EfiRuntimeServicesData.  However, EfiRuntimeServices*
> > > memory needs to be included in the EFI page tables, so it is best to
> > > minimize the amount of memory of this type.  Since EFI runtime services
> > > do not need access to the ESRT, EfiACPIReclaimMemory is a better choice.
> > >
> > > Link: https://lists.xenproject.org/archives/html/xen-devel/2022-
> > 09/msg01365.html
> > > Fixes: dc7da0874ba4 ("EFI: preserve the System Resource Table for dom0")
> > > Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > > Should this be included in 4.17?  It is a bug fix for a feature new to
> > > 4.17, so I suspect yes, but it is ultimately up to Henry Wang.  The code
> > > is identical to v2, but I have improved the commit message.
> > It may be too late now, looking at the state of the tree. Henry, Julien?
> Like I said in v2, I don't object the change if you would like to include this 
> patch
> to 4.17, so if you are sure this patch is safe and want to commit it, feel free 
> to add:
>
> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Since we also need to commit:
> "[PATCH for-4.17] SUPPORT.md: Define support lifetime" so from my side
> I am no problem. Julien might have different opinion though, if Julien object
> the change I would like to respect his opinion and leave this patch uncommitted.
I have committed it after SUPPORT.md. So if for some reasons we are seen 
any issues with Osstest, then I can tag the tree without this patch 
(that said, I would rather prefer if we have staging-4.17 == stable-4.17).
My plan is to prepare the tarball tomorrow.

Cheers,

--
Julien Grall