[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xsm/flask: misra rule 8.4 fix
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 8 Dec 2022 09:37:37 -0500
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670510262; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=h28PH3SivYi1nEcbXtVQMxx4cEMNHT5Jco8sKuWi9ZM=; b=lbZSJn3ZbXQT7Dr6qQ7iTW89k5dZSfiasgytr3h9Oxnnz/cgvMpjRG4ly/0bUMKEzPCD5s7UzO6NMmNjyk/83E5bi2BtsYTUHjth4H4PIxFryioI7kJZJESNLBLn8+NAdEHKpqTg9G2r+u2zPr/y7Z5h6JSCgOuyj602s1+4C3A=
- Arc-seal: i=1; a=rsa-sha256; t=1670510262; cv=none; d=zohomail.com; s=zohoarc; b=CxX50lKZr1EuHEt8z9yIAfyfkobxTEcr2n1wnKuOfIX26fnTKle5HJP+thJIidTvZ3mXPdO/YdExLwOEoevkLFV2NrDc8u98S0WdkvblUZk94nNiN7ZtGQS+uxcFKZjIxq74D/ipPxfxODS1NEBNoRrYrFJHDwH3TiYnghnRbzE=
- Cc: jbeulich@xxxxxxxx, michal.orzel@xxxxxxx
- Delivery-date: Thu, 08 Dec 2022 14:37:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/7/22 18:24, Stefano Stabellini wrote:
Fix several MISRA Issues Rule 8.4 ("A compatible declaration shall be
visible when an object or function with external linkage is defined")
found by cppcheck affecting xen/xsm/flask.
- policydb_loaded_version is not declared; removed it because it is
unused
- move ss_initialized declaration to xen/xsm/flask/include/conditional.h
- #include <conditional.h> (which is
xen/xsm/flask/include/conditional.h) in xen/xsm/flask/ss/policydb.c so
that policydb.c also gets the declaration of ss_initialized
- #include <conditional.h> in xen/xsm/flask/ss/services.c to declare
security_*_bools functions that services.c is defining and using
This patch solves all the Rule 8.4 violations found by cppcheck on xsm/
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
Ack-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
