[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping: [PATCH v2] xen: credit2: respect credit2_runqueue=all when arranging runqueues
- To: Dario Faggioli <dfaggioli@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Dec 2022 12:41:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qeye4Yp9faDNp0AuKR7PsZOBMxJmqTN0aF0drAqZHzE=; b=N+5xUZIoDYrop9dPrL9/fz2F2NG2eLi1hPEE5iGQ4fvlx1KaQsiPqupeDgiqgj/jp//t6lRN+knMe39aNARUaMI5gIWnKvJVFZ3rlMaCmm6TYWPv5Q5EZb4e8gb+H2Z0oPufTZ6d6qKXofn0u5wRS44Sx65KcX00CRUOqA1aEQhVZbRzFZmqkZ8icOlYQ78kS30dzwefD0dV+0hD8u8n1+roankBTZOfFwXx3iXPX1o4yU2pGGvETjykSK+jDSb4LMrC7qY1VbTq/fG+1gwlfvShvrofkp3jW9w1GNOHZautmDbcWWlZSh1olwEWDMfL7wAlEfbRpB7dbD06ePW4Zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h0t7EvRR4eaDFoysf7Le1XO/IfeMfyMWV29+vhmMBkZH3tK6Up1Sbg/miOQ/LZUOjm+5tjcBxyjOSPJ38I1tJzvnktNgQT+Ii1Iilkdfo62XkRB4y1FXbq5zO7VR/RRd1YqVv4/fAobY65Bd/JP2Oio6Fp3ticwAi3eBmSpXS9O94POZHLAaPK0wyh0giB2C00ywVch9ssQvdvWEvg2rlaMEl5Mxf55vHnkAHooxrjIlbg1DKYhgShfEqYY+8TR87GAzMnVB8vKSFtjBr8IT+JKrqEIb63hxwM2o8xY/ZjphJid4I7luVzxEzi7Gzpt40LpoNFg7zlUer/u6SwPfLw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Dec 2022 11:41:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.10.2022 18:21, Marek Marczykowski-Górecki wrote:
> Documentation for credit2_runqueue=all says it should create one queue
> for all pCPUs on the host. But since introduction
> sched_credit2_max_cpus_runqueue, it actually created separate runqueue
> per socket, even if the CPUs count is below
> sched_credit2_max_cpus_runqueue.
>
> Adjust the condition to skip syblink check in case of
> credit2_runqueue=all.
>
> Fixes: 8e2aa76dc167 ("xen: credit2: limit the max number of CPUs in a
> runqueue")
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> Changes in v2:
> - fix indentation
> - adjust doc
>
> The whole thing is under cpu_runqueue_match() already, so maybe
> cpu_runqueue_siblings_match() isn't needed at all?
> ---
> docs/misc/xen-command-line.pandoc | 5 +++++
> xen/common/sched/credit2.c | 9 +++++++--
> 2 files changed, 12 insertions(+), 2 deletions(-)
George, Dario - any chance of an ack (or reasons not to)?
Jan
|
