[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Dec 2022 11:11:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TroBOdUX5HfBGqTjb4GCit156LcMDpVDMRjHzR3YSVU=; b=Ww/91U0w3L+VG7pAiZTO+zqEObZpHP5pncnDN7cjfs9Vj/miCLxfFdGLuNaESuEOGLfvJ+RNy2z/M9xdeBKtmIvENDHzAW9mJI3kMbEyefv47knNaZc0DJZZqEjjA2sbEYCjK41pgVBqCBgDiLGyK8TZVfiQUcIhWQ0bOZ0+YHWR+hfC8OrivusUdhfrkf+kzso3tgu6plF7JXBtibNpffIvxeaRfA7WbEjvziGrEbkS0MqkzkNYnNaxR3mOErTHmV4IlSPNK1QbcRIq32frTtZF5YXhq/6GL9K9/FBFbonX3VV0/Z8/7wwPrltzuVvQw0Raxq636vQyjMGWadsmkQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C99zVsvAMCbjdqDLUA/zQaaZlEDne2MS8e9MIaznT0MrxeXC4DamurIYu7eQu6BmjxCmSPmWRbw5HLCXGr/bJ89AQI0zL4pVj/0lrWUdWi7+amjcNOwzzOyqS7jZLHvB/HGgPYpQuJUYAE80SCyMlRr5MkBkVkrwf7fu/gQCO6GgT2hTzZquvtuP53FMwZ8zyojScXJ1YHYM9baS1TnpYI9XtLjCUW694LpROJ912ZdIRHvqCK0muSrDzVINwovRt4SnEQhy2CIF3hMYaG+pP2C02T7GI/DsNrf+bdlBBXM9pOUbbNuhgeb7A7MoJg+QvGRPbm2Xz7AMqAqbAF8Ypg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Ard Biesheuval <ardb@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Dec 2022 10:11:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.12.2022 00:27, Demi Marie Obenour wrote:
> A previous patch tried to get Linux to use the ESRT under Xen if it is
> in memory of type EfiRuntimeServicesData. However, this turns out to be
> a bad idea. Ard Biesheuvel pointed out that EfiRuntimeServices* memory
> winds up fragmenting both the EFI page tables and the direct map, and
> that EfiACPIReclaimMemory is a much better choice for this purpose.
>
> Link:
> https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg01365.html
> Fixes: dc7da0874ba4 ("EFI: preserve the System Resource Table for dom0")
> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> Should this be included in 4.17? It is a bug fix for a feature new to
> 4.17, so I suspect yes, but it is ultimately up to Henry Wang.
First I was surprised this is numbered v2. But it indeed looks to be a
plain re-submission, merely with Henry Cc-ed. You didn't address my
comments; you didn't even incorporate the one adjustment where you
suggested alternative wording and where I did signal my agreement. All
this form of plain re-submission (without any kind of remark in that
direction) did is that I spent (wasted) time checking what the earlier
variant had, what was requested to be changed, and whether any of the
changes were actually carried out.
Jan
|
